From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C1FC43381 for ; Tue, 19 Feb 2019 00:39:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 079BB217F5 for ; Tue, 19 Feb 2019 00:39:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732442AbfBSAja (ORCPT ); Mon, 18 Feb 2019 19:39:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56728 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfBSAja (ORCPT ); Mon, 18 Feb 2019 19:39:30 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 18FAC11D424B2; Mon, 18 Feb 2019 16:39:30 -0800 (PST) Date: Mon, 18 Feb 2019 16:39:29 -0800 (PST) Message-Id: <20190218.163929.392524795104104591.davem@davemloft.net> To: hkallweit1@gmail.com Cc: nic_swsd@realtek.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] r8169: remove unneeded mmiowb barriers From: David Miller In-Reply-To: <10883db9-493c-7434-2379-de79712cee85@gmail.com> References: <10883db9-493c-7434-2379-de79712cee85@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Feb 2019 16:39:30 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sat, 16 Feb 2019 10:20:15 +0100 > writex() has implicit barriers, that's what makes it different from > writex_relaxed(). Therefore these calls to mmiowb() can be removed. > > This patch was recently reverted due to a dependency with another > problematic patch. But because it didn't contribute to the problem > it was rebased and can be resubmitted. > > Signed-off-by: Heiner Kallweit Applied.