Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jose.abreu@synopsys.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	joao.pinto@synopsys.com, peppe.cavallaro@st.com,
	alexandre.torgue@st.com
Subject: Re: [PATCH net] net: stmmac: Fix a race in EEE enable callback
Date: Mon, 18 Feb 2019 17:40:07 -0800 (PST)	[thread overview]
Message-ID: <20190218.174007.481602281794068390.davem@davemloft.net> (raw)
In-Reply-To: <fb866bb5dd8a11326fab8e6d393f2a37eed5073f.1550496861.git.joabreu@synopsys.com>

From: Jose Abreu <jose.abreu@synopsys.com>
Date: Mon, 18 Feb 2019 14:35:03 +0100

> We are saving the status of EEE even before we try to enable it. This
> leads to a race with XMIT function that tries to arm EEE timer before we
> set it up.
> 
> Fix this by only saving the EEE parameters after all operations are
> performed with success.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")

Applied and queued up for -stable, thanks.

      reply	other threads:[~2019-02-19  1:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 13:35 [PATCH net] net: stmmac: Fix a race in EEE enable callback Jose Abreu
2019-02-19  1:40 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218.174007.481602281794068390.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexandre.torgue@st.com \
    --cc=joao.pinto@synopsys.com \
    --cc=jose.abreu@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox