From: Niklas Cassel <niklas.cassel@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: David S Miller <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
Date: Mon, 18 Feb 2019 11:28:28 +0100 [thread overview]
Message-ID: <20190218102828.GA25677@centauri.lan> (raw)
In-Reply-To: <20190218101853.4290-1-vkoul@kernel.org>
On Mon, Feb 18, 2019 at 03:48:52PM +0530, Vinod Koul wrote:
> Some helpers were inlined, but makes more sense to allow compiler
> to do the right optiomazations instead, so remove inline for
> at803x_disable_rx_delay() and at803x_disable_tx_delay()
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/net/phy/at803x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 8ff12938ab47..c6e7d800fd7a 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
> return phy_write(phydev, AT803X_DEBUG_DATA, val);
> }
>
> -static inline int at803x_disable_rx_delay(struct phy_device *phydev)
> +static int at803x_disable_rx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
> AT803X_DEBUG_RX_CLK_DLY_EN, 0);
> }
>
> -static inline int at803x_disable_tx_delay(struct phy_device *phydev)
> +static int at803x_disable_tx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5,
> AT803X_DEBUG_TX_CLK_DLY_EN, 0);
> --
> 2.20.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
next prev parent reply other threads:[~2019-02-18 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-18 10:28 ` Niklas Cassel
2019-02-18 14:40 ` Peter Ujfalusi
2019-02-18 10:28 ` Niklas Cassel [this message]
2019-02-19 0:28 ` [PATCH v2 1/2] net: phy: at803x: dont inline helpers David Miller
2019-02-19 5:02 ` Vinod Koul
2019-02-19 5:35 ` Sekhar Nori
2019-02-19 5:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218102828.GA25677@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).