From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BECC43381 for ; Mon, 18 Feb 2019 10:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1725F214DA for ; Mon, 18 Feb 2019 10:28:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sCe1aE6A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729400AbfBRK2d (ORCPT ); Mon, 18 Feb 2019 05:28:33 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:37907 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727307AbfBRK2d (ORCPT ); Mon, 18 Feb 2019 05:28:33 -0500 Received: by mail-lf1-f68.google.com with SMTP id n15so11891584lfe.5 for ; Mon, 18 Feb 2019 02:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5K5PYxsSDu7ba5/ir7OlS0Gr9RJDgQvQ+dyWeOdfZ/o=; b=sCe1aE6Ab2PA+hVh1I/B+naf59nuVGhvH6EQ8JR+2vXfoxgCkl+V0CulR1teZbG1gS qBpMseeVsBM2kSoF37LX3LJdYz+snAKttmhrnf3BHCVGTksSfXW7Ut75XCT6J0YPlALQ IPFgVanjHbOHpF9OyIiEFGcuLPVqfnnlrjqFTWMJ04yYxkTsTapU3wxSYsyO6/fA6qL/ 3KDDN9SUmIVSuWvgFYrU8iZv5QBylKqUdLcDdGP3VWMpSFhaLc6yztPdYnuc0FerWtWV cpZeUXNV5xfrn5N/1I3huQjHhb7+eiCes8D+OitVkqUVR4UBc8AQNpYs43muI2nLQ2+E wvPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5K5PYxsSDu7ba5/ir7OlS0Gr9RJDgQvQ+dyWeOdfZ/o=; b=jEQIJ+4DGswDE6wOLQZxZDbktvfQ6iNJjlxH5zW6+MwdNOK+pyHWA7sZ5bNB4k5dg0 BkJo+cNPWg9SjJegTG8CxPfuGyaHr1C2hDv8svHjlgPh5dO97YZlRF5CkPPRpw2ZUZKb ovJxIRmL6UaSMC9I6G2/4D5tFiMG3MCYLErJ4YEeljJBAWX7VMifyQtXbMDQ49QqcK3U 1LpsSnvMiUxBIceiviEQ4h4OZTwz8xcQ7gddDzyMly2LzTUUw4ww/nEZOHZ45CvLtmlz 6NQXiYhgFSvrHlSR5sUUqS2AVYmcsWrk5fh9UW6eG2klmM4D/JF2FV5s4z4BvR30Dbz0 bO/Q== X-Gm-Message-State: AHQUAuYjNcIG7pQa5Lf6Z6rFTVT9dj+ujfcExm5H33iZN5Q9i18ikknS RShRc/OhszR4HotY2sB6XxXWNqTwkr4= X-Google-Smtp-Source: AHgI3Ib+79UmVBiYtB13+YI9Hec1wI+3a747+bZbtty434tP3n/ENeb1RiHhFuu82pV3OYpKP3b+XA== X-Received: by 2002:ac2:4219:: with SMTP id y25mr13257902lfh.130.1550485710863; Mon, 18 Feb 2019 02:28:30 -0800 (PST) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id v66sm3615693lfa.74.2019.02.18.02.28.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 18 Feb 2019 02:28:30 -0800 (PST) Date: Mon, 18 Feb 2019 11:28:28 +0100 From: Niklas Cassel To: Vinod Koul Cc: David S Miller , linux-arm-msm@vger.kernel.org, Bjorn Andersson , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , "Nori, Sekhar" , Peter Ujfalusi , Marc Gonzalez Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers Message-ID: <20190218102828.GA25677@centauri.lan> References: <20190218101853.4290-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218101853.4290-1-vkoul@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 18, 2019 at 03:48:52PM +0530, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optiomazations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > Signed-off-by: Vinod Koul > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); > -- > 2.20.1 > Reviewed-by: Niklas Cassel