From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3B0C43381 for ; Mon, 18 Feb 2019 10:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74F5E2176F for ; Mon, 18 Feb 2019 10:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730169AbfBRKw2 (ORCPT ); Mon, 18 Feb 2019 05:52:28 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60795 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728258AbfBRKw2 (ORCPT ); Mon, 18 Feb 2019 05:52:28 -0500 X-Originating-IP: 90.88.30.68 Received: from localhost (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: antoine.tenart@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4A0EEE0011; Mon, 18 Feb 2019 10:52:23 +0000 (UTC) Date: Mon, 18 Feb 2019 11:52:22 +0100 From: Antoine Tenart To: Russell King - ARM Linux admin Cc: Antoine Tenart , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com Subject: Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes Message-ID: <20190218105222.GD3784@kwain> References: <20190215153241.6857-1-antoine.tenart@bootlin.com> <20190215153241.6857-11-antoine.tenart@bootlin.com> <20190215171224.sjfrid5csseywuks@shell.armlinux.org.uk> <20190218102630.GA3784@kwain> <20190218104302.bp6ccmpkt26dflyx@shell.armlinux.org.uk> <20190218104757.be63b5ft5jpongn3@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190218104757.be63b5ft5jpongn3@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Russell, On Mon, Feb 18, 2019 at 10:47:57AM +0000, Russell King - ARM Linux admin wrote: > > Another case that needs to be considered: if the XPCS should be placed > into reset while reconfiguring the serdes lanes, is the same treatment > needed for the GMAC? That's something I wanted to check as well. I don't know for the GMAC, while I'm sure the documentation explicitly state to put the XPCS in reset when reconfiguring the lanes. Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com