From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013EFC43381 for ; Mon, 18 Feb 2019 20:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C203D217F5 for ; Mon, 18 Feb 2019 20:15:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="R+TMSDQd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729099AbfBRUPY (ORCPT ); Mon, 18 Feb 2019 15:15:24 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38310 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727400AbfBRUPX (ORCPT ); Mon, 18 Feb 2019 15:15:23 -0500 Received: by mail-pf1-f194.google.com with SMTP id n125so1822580pfn.5 for ; Mon, 18 Feb 2019 12:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=9S1roozBhtfxLjQTxCHEWpyGhKQcR4X2KUsQI8j8/m0=; b=R+TMSDQdV+ptFc7vR5wBpE/1xq5P5xv51RgJRwljNj/v0xtoFJRO15wtZRtiCAG/YK vVwPdLOBfdmsZTVn80TpnVu31zqm4lkTL51p3pHozFL0CLhtWh8ygtjP6xdwJLIq2GLR Y62RNqyB+f2EmYlbjHLle6v9+qLgrO4ONvROqWzAMB0iufXqWKFUENO8WyLJN6qj2iJ2 zxIS3ZvUE947r0rPSu9B/LF1PHi73+oAVJ7UZT3pV2s9VNyRpF4lDBxBDE2HTpu4RVlo WOwQ+YZV8rBc0G6zAYJKRARmuqPgDt3OE3frZl3LbxwDecrdBrHBVTSAsA+T7vY5gMT6 Ty4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=9S1roozBhtfxLjQTxCHEWpyGhKQcR4X2KUsQI8j8/m0=; b=KKVdZNACN+m6d74kxFdn8gomrkHckpw3Fz78NHf+J2gJk+eA6NdHUSF/puTNtkixjg ukgaGkvFsXtnL+M+uxDkDXz+1UczoYeZ2JXIdyYwAq+S2j08B5WVyGhgTFr7IQdItFvd WJs7OU78KfUq1dQKeuTztu3TvYmLwwP72ZWMDaW3d5s05GH71x77wMVbcava6UAEe3KX 8tTSmuv7jV5K1w5Yswge34dYs6GGloAYRhK5lbzLr481AR5wxaQs9yqHs/LpfMhulKtu DLcnhIkiwwDnVaNnA+4bBMzZgwSR4QPPPwIK0hyJ82zpfzzLXOtO3exTU2i1SaMtamDM 9NYQ== X-Gm-Message-State: AHQUAuYNOoSxNWCbvOJ9/lAmRXr6D/45YEUjZOCk3QnvlQAe/gFu/9FJ p3I37eI16tQBTYFoP3ieFtedqQ== X-Google-Smtp-Source: AHgI3IYMCYhL4Mocr+eAcJBzS9mQ40XSoHUX2Um+n58K4gililX8sehR9XYLIzUFdryAX+ABgAoCNg== X-Received: by 2002:a63:aa46:: with SMTP id x6mr20614981pgo.452.1550520922764; Mon, 18 Feb 2019 12:15:22 -0800 (PST) Received: from cakuba.netronome.com ([2601:646:8e00:1b7a::3]) by smtp.gmail.com with ESMTPSA id d131sm23062273pfd.108.2019.02.18.12.15.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Feb 2019 12:15:22 -0800 (PST) Date: Mon, 18 Feb 2019 12:15:17 -0800 From: Jakub Kicinski To: Michal Kubecek Cc: netdev@vger.kernel.org, David Miller , Andrew Lunn , Jiri Pirko , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for netlink interface Message-ID: <20190218121517.4d299f6e@cakuba.netronome.com> In-Reply-To: <266b4ea3596de134329f8bbd5d13e282d1d27442.1550513384.git.mkubecek@suse.cz> References: <266b4ea3596de134329f8bbd5d13e282d1d27442.1550513384.git.mkubecek@suse.cz> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote: > +/* create skb for a reply and fill device identification > + * payload: payload length (without netlink and genetlink header) > + * dev: device the reply is about (may be null) > + * cmd: ETHNL_CMD_* command for reply > + * info: info for the received packet we respond to > + * ehdrp: place to store payload pointer returned by genlmsg_new() > + * returns: skb or null on error > + */ nit: why not correct kdoc? > +struct sk_buff *ethnl_reply_init(size_t payload, struct net_device *dev, u8 cmd, > + u16 dev_attrtype, struct genl_info *info, > + void **ehdrp) > +{ > + void *ehdr; > + struct sk_buff *rskb; nit: reverse xmas tree