From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iwK6=QZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 12622C43381
	for <netdev@archiver.kernel.org>; Mon, 18 Feb 2019 13:36:28 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id CAC49218AD
	for <netdev@archiver.kernel.org>; Mon, 18 Feb 2019 13:36:27 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Ti+6fih4"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731176AbfBRNg1 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 18 Feb 2019 08:36:27 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:56814 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727483AbfBRNg0 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 18 Feb 2019 08:36:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=UKii8lMRmIy0r/ulrasckwZtMme1FykhLt4tAzscM4E=; b=Ti+6fih4j/rp9c8pI0KBENOedy
        hneLQCCP1y//Ee4cvc+7IRoB4+FGfIug53ome2qjkUNM0NyoDVKawDY1cgzJ4Zno097tmGFRaVJ4S
        SWYsD7R/tEqaA6xfoYEOQ0QKA89udqL6WgYlNI7zWUCBW+qYwSG9ltucdaTUPiCMp474=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gvj5p-0006JC-VY; Mon, 18 Feb 2019 14:36:21 +0100
Date:   Mon, 18 Feb 2019 14:36:21 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     David S Miller <davem@davemloft.net>,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        netdev@vger.kernel.org, Niklas Cassel <niklas.cassel@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michal =?utf-8?B?Vm9rw6HEjQ==?= <michal.vokac@ysoft.com>
Subject: Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode
Message-ID: <20190218133621.GC14879@lunn.ch>
References: <20190218130352.9373-1-vkoul@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190218130352.9373-1-vkoul@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> +	case PHY_INTERFACE_MODE_RGMII_ID:
> +		/* RGMII_ID needs internal delay. This is enabled through
> +		 * PORT5_PAD_CTRL for all ports, rather than individual port
> +		 * registers
> +		 */
> +		qca8k_write(priv, reg,
> +			    QCA8K_PORT_PAD_RGMII_EN |
> +			    QCA8K_PORT_PAD_RGMII_TX_DELAY(3) |
> +			    QCA8K_PORT_PAD_RGMII_RX_DELAY(3));

Hi Vinod

Could you add some #defines for the delay values?

    Thanks
	Andrew