From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B598C43381 for ; Mon, 18 Feb 2019 16:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C6A8214DA for ; Mon, 18 Feb 2019 16:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389064AbfBRQ0S (ORCPT ); Mon, 18 Feb 2019 11:26:18 -0500 Received: from muru.com ([72.249.23.125]:39312 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731218AbfBRQ0R (ORCPT ); Mon, 18 Feb 2019 11:26:17 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D65D380E4; Mon, 18 Feb 2019 16:26:26 +0000 (UTC) Date: Mon, 18 Feb 2019 08:26:13 -0800 From: Tony Lindgren To: Peter Ujfalusi Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com, grygorii.strashko@ti.com, vkoul@kernel.org, netdev@vger.kernel.org, f.fainelli@gmail.com, marc.w.gonzalez@free.fr, niklas.cassel@linaro.org Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet Message-ID: <20190218162613.GH15711@atomide.com> References: <20190218143629.28392-1-peter.ujfalusi@ti.com> <20190218144430.GE15711@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Peter Ujfalusi [190218 16:22]: > > > On 18/02/2019 16.44, Tony Lindgren wrote: > > * Peter Ujfalusi [190218 14:36]: > >> Hi, > >> > >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the > >> ethernet networking on evmsk (and most likely on the evm as well): > >> https://patchwork.ozlabs.org/patch/1028527/ > >> > >> v1 patch to fix the situation: > >> https://patchwork.ozlabs.org/patch/1040617/ > >> > >> It turned out that the at803x driver is actually broken and need to be fixed > >> along with the DT data. > >> > >> The following series is proposed to fix the driver: > >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611 > >> > >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid: > >> The rx delay is enabled by default and the driver never disabled it so when > >> asking rgmii-txid it actually got rgmii-id. > >> > >> The patch can be backported to stable, I have tested that it is not causing > >> regression with the old, broken driver. > > > > Can the dts changes be merged before the driver changes or > > does it cause the phy to stop working? > > The phy is not working atm, but this change will not cause regression > even if it is merged first. OK so sounds like these are OK to wait for v5.1 merge window then as the dts changes alone won't fix anything? Regards, Tony