From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7337EC43381 for ; Tue, 19 Feb 2019 22:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48F9C21738 for ; Tue, 19 Feb 2019 22:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729786AbfBSWLE (ORCPT ); Tue, 19 Feb 2019 17:11:04 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:41484 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726962AbfBSWLD (ORCPT ); Tue, 19 Feb 2019 17:11:03 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A7B921086DDE8; Tue, 19 Feb 2019 14:11:02 -0800 (PST) Date: Tue, 19 Feb 2019 14:11:00 -0800 (PST) Message-Id: <20190219.141100.1059737970253170004.davem@davemloft.net> To: maowenan@huawei.com Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr, wharms@bfs.de Subject: Re: [PATCH v4] net: ns83820: code cleanup for ns83820_probe_phy() From: David Miller In-Reply-To: <20190219134510.51835-1-maowenan@huawei.com> References: <20190219134510.51835-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Feb 2019 14:11:03 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mao Wenan Date: Tue, 19 Feb 2019 21:45:10 +0800 > This patch is to do code cleanup for ns83820_probe_phy(). > It deletes unused variable 'first', commented out code, > and the pointless 'for' loop. > > Signed-off-by: Mao Wenan > Acked-by: Julia Lawall > --- > v3->v4: delete pointless 'for' loop, variable 'i', and so on. Before pushing out I realized I applied v3 instead of this v4, but that's now fixed up.