From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=YZVD=Q2=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB05C43381
	for <netdev@archiver.kernel.org>; Tue, 19 Feb 2019 05:00:27 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 1E2F821900
	for <netdev@archiver.kernel.org>; Tue, 19 Feb 2019 05:00:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1550552427;
	bh=2W22jqoHhyy+4zepG0cdrjzanmESnQZvpAG2SSFFW9k=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=nks3TyMU/fFShc5Le5edp2YgGoSSNVCXStCzhTxXxmwvq2kcI3EHFN2HwkEXT1tf+
	 zNST+NGVYJJk7zw8Do6xA3QOSVEW9nfjXjVvWDnF9P1vEjZSWYYth8tFhnW9bCYr9o
	 vp+PoevRUKLZoRQZCLEbvcEwviLzIJR3krQLi2BQ=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725803AbfBSFA0 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 19 Feb 2019 00:00:26 -0500
Received: from mail.kernel.org ([198.145.29.99]:54342 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725681AbfBSFA0 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 19 Feb 2019 00:00:26 -0500
Received: from localhost (unknown [106.200.226.2])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id A5BC5217D9;
        Tue, 19 Feb 2019 05:00:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1550552425;
        bh=2W22jqoHhyy+4zepG0cdrjzanmESnQZvpAG2SSFFW9k=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=SewBkS3yw9JyYWXadnWgHj5xoV0U5Xlt6VnCjSMzE3hi4Cxp5Z3mbwaBIkfALb4AV
         luPVpjooIuJqOSsJuiZopUHuEJt2T0S5ixo5m3Fe7ezSBx4jJzyYhDOvFAWpXtaTBE
         t8oazTx4D7A15nrJgxZsezS/Rvb4jizBONM//gfk=
Date:   Tue, 19 Feb 2019 10:30:16 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     David S Miller <davem@davemloft.net>,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        netdev@vger.kernel.org, Niklas Cassel <niklas.cassel@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michal =?utf-8?B?Vm9rw6HEjQ==?= <michal.vokac@ysoft.com>
Subject: Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode
Message-ID: <20190219050016.GS21884@vkoul-mobl>
References: <20190218130352.9373-1-vkoul@kernel.org>
 <20190218133621.GC14879@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190218133621.GC14879@lunn.ch>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On 18-02-19, 14:36, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> > +	case PHY_INTERFACE_MODE_RGMII_ID:
> > +		/* RGMII_ID needs internal delay. This is enabled through
> > +		 * PORT5_PAD_CTRL for all ports, rather than individual port
> > +		 * registers
> > +		 */
> > +		qca8k_write(priv, reg,
> > +			    QCA8K_PORT_PAD_RGMII_EN |
> > +			    QCA8K_PORT_PAD_RGMII_TX_DELAY(3) |
> > +			    QCA8K_PORT_PAD_RGMII_RX_DELAY(3));
> 
> Hi Vinod
> 
> Could you add some #defines for the delay values?

Sure will update the patch

-- 
~Vinod