From: Vinod Koul <vkoul@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch,
f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com,
marc.w.gonzalez@free.fr
Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
Date: Tue, 19 Feb 2019 10:32:27 +0530 [thread overview]
Message-ID: <20190219050227.GT21884@vkoul-mobl> (raw)
In-Reply-To: <20190218.162850.1254388175691397706.davem@davemloft.net>
Hello Dave,
On 18-02-19, 16:28, David Miller wrote:
> From: Vinod Koul <vkoul@kernel.org>
> Date: Mon, 18 Feb 2019 15:48:52 +0530
>
> > Some helpers were inlined, but makes more sense to allow compiler
> > to do the right optiomazations instead, so remove inline for
> > at803x_disable_rx_delay() and at803x_disable_tx_delay()
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Two problem with this patch series.
>
> 1) It fixes a bug in 'net' but the patches only apply cleanly to
> 'net-next'. Please respin this against 'net'.
I assume the 'net' is fixes going into current -rcX. This fixes issues
reported on linux-next due to patches in net-next, so these fixes should
go to net-next as well.
> 2) This series lacks a header posting "[PATCH vX 0/N] " which
> explains at a high level what the series is doing, how it is
> doing it, and why it is doing it that way.
Sure I will add this and repost
Thanks
--
~Vinod
next prev parent reply other threads:[~2019-02-19 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-18 10:28 ` Niklas Cassel
2019-02-18 14:40 ` Peter Ujfalusi
2019-02-18 10:28 ` [PATCH v2 1/2] net: phy: at803x: dont inline helpers Niklas Cassel
2019-02-19 0:28 ` David Miller
2019-02-19 5:02 ` Vinod Koul [this message]
2019-02-19 5:35 ` Sekhar Nori
2019-02-19 5:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219050227.GT21884@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).