From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B845C43381 for ; Tue, 19 Feb 2019 05:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C1E921900 for ; Tue, 19 Feb 2019 05:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550552557; bh=G1dsX4HmDf4/XjXBepD23Ue4ksO6/mMCIpT/QEEJi8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cEBv0+OZ3TBpewj04k5DNuAz72B2uHBUZcTTQKy0qzOieuLY0KWRZFlK7+winjNFZ QgzE3AQZTGjSuGC/Y8crvqwNSHn9S77IXJdQAkyJFT70irJBPDNB4R1qBYXG3NqApo DhNm6PRll0raJWjQY9QOOcxEHNg/8DQHzdI38EiU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725807AbfBSFCg (ORCPT ); Tue, 19 Feb 2019 00:02:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:55740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfBSFCg (ORCPT ); Tue, 19 Feb 2019 00:02:36 -0500 Received: from localhost (unknown [106.200.226.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAC39217D9; Tue, 19 Feb 2019 05:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550552555; bh=G1dsX4HmDf4/XjXBepD23Ue4ksO6/mMCIpT/QEEJi8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=08n4HcQ3WRkGLS/sEm6olfO4OI1+L15fUhNOywahDt/mU9tFAeLf9cN5lICE6gE5D 3+CFQykzfZtbSSItvifjFnBZCb4kWCKl4Roe3Zmf/KoMtiBcEvOnMBtTHCm75jfw9b lMODRHitlnRg6n8CCAzwcFSmzlQxxR8bazt5gsyw= Date: Tue, 19 Feb 2019 10:32:27 +0530 From: Vinod Koul To: David Miller Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com, marc.w.gonzalez@free.fr Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers Message-ID: <20190219050227.GT21884@vkoul-mobl> References: <20190218101853.4290-1-vkoul@kernel.org> <20190218.162850.1254388175691397706.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218.162850.1254388175691397706.davem@davemloft.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Dave, On 18-02-19, 16:28, David Miller wrote: > From: Vinod Koul > Date: Mon, 18 Feb 2019 15:48:52 +0530 > > > Some helpers were inlined, but makes more sense to allow compiler > > to do the right optiomazations instead, so remove inline for > > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > > > Signed-off-by: Vinod Koul > > Two problem with this patch series. > > 1) It fixes a bug in 'net' but the patches only apply cleanly to > 'net-next'. Please respin this against 'net'. I assume the 'net' is fixes going into current -rcX. This fixes issues reported on linux-next due to patches in net-next, so these fixes should go to net-next as well. > 2) This series lacks a header posting "[PATCH vX 0/N] " which > explains at a high level what the series is doing, how it is > doing it, and why it is doing it that way. Sure I will add this and repost Thanks -- ~Vinod