From: Mao Wenan <maowenan@huawei.com>
To: <kernel-janitors@vger.kernel.org>, <netdev@vger.kernel.org>,
<john.fastabend@gmail.com>, <hawk@kernel.org>,
<jakub.kicinski@netronome.com>, <daniel@iogearbox.net>,
<ast@kernel.org>
Subject: [PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()
Date: Tue, 19 Feb 2019 16:42:14 +0800 [thread overview]
Message-ID: <20190219084214.96202-1-maowenan@huawei.com> (raw)
There is no need to have the 'int first' static
since new value always be assigned before use it.
This patch cleans up the codes in ns83820_probe_phy() as well.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
v1->v2: delete unused codes.
drivers/net/ethernet/natsemi/ns83820.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index 958fced4dacf..37694f6843fe 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -1869,23 +1869,11 @@ static unsigned ns83820_mii_write_reg(struct ns83820 *dev, unsigned phy, unsigne
static void ns83820_probe_phy(struct net_device *ndev)
{
struct ns83820 *dev = PRIV(ndev);
- static int first;
+ int first;
int i;
#define MII_PHYIDR1 0x02
#define MII_PHYIDR2 0x03
-#if 0
- if (!first) {
- unsigned tmp;
- ns83820_mii_read_reg(dev, 1, 0x09);
- ns83820_mii_write_reg(dev, 1, 0x10, 0x0d3e);
-
- tmp = ns83820_mii_read_reg(dev, 1, 0x00);
- ns83820_mii_write_reg(dev, 1, 0x00, tmp | 0x8000);
- udelay(1300);
- ns83820_mii_read_reg(dev, 1, 0x09);
- }
-#endif
first = 1;
for (i=1; i<2; i++) {
@@ -1894,9 +1882,6 @@ static void ns83820_probe_phy(struct net_device *ndev)
a = ns83820_mii_read_reg(dev, i, MII_PHYIDR1);
b = ns83820_mii_read_reg(dev, i, MII_PHYIDR2);
- //printk("%s: phy %d: 0x%04x 0x%04x\n",
- // ndev->name, i, a, b);
-
for (j=0; j<0x16; j+=4) {
dprintk("%s: [0x%02x] %04x %04x %04x %04x\n",
ndev->name, j,
--
2.20.1
next reply other threads:[~2019-02-19 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 8:42 Mao Wenan [this message]
2019-02-19 8:31 ` [PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy() Julia Lawall
2019-02-19 8:39 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219084214.96202-1-maowenan@huawei.com \
--to=maowenan@huawei.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox