From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66CBC43381 for ; Tue, 19 Feb 2019 09:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 633E121738 for ; Tue, 19 Feb 2019 09:29:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="bKgx4iZ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727203AbfBSJ3U (ORCPT ); Tue, 19 Feb 2019 04:29:20 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40054 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfBSJ3U (ORCPT ); Tue, 19 Feb 2019 04:29:20 -0500 Received: by mail-wm1-f67.google.com with SMTP id t15so1729068wmi.5 for ; Tue, 19 Feb 2019 01:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KkmHcyIJLdnu1jKNdlUpgiNmR7bA/knRE7n7+EIoC4E=; b=bKgx4iZ6r6ep5eIVQLGfIDtO5i9RcWsAoP1atD97ZUWSJmxuzGpzio26N68wYTdbsO FqDtUzW2HXMXhiDcGm6+6y9dqU2cXhyGjfZ3+ihUY6xiPzcN5k26d3rvR3R1jlqwMppS 18BjF8cmZ697Pn2hF0qPz4rUWbk/nVaRla/SPBoSrNmDMqxfGWIO0DGMWiGmYih/CaWP AZ1EegBLHlYfAB4myO1pLudhFTJhYHHNXBFN5LOOa1k+A2Kh2xjc+c1zOBeGcOkcv8rV nbbLwJQz3fGSd4P1lBMDPIUEk9PqY2++5b5vneDVdnFLxQpMuZldQ32rV4C+mxmmFeg/ T29A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KkmHcyIJLdnu1jKNdlUpgiNmR7bA/knRE7n7+EIoC4E=; b=j915dJDgM7cKTsWcPoFGAHHjZLrc82X1BRe5rVdNvs5lNg33FqvrqoQ4cOs4Kceji4 qbh1J5YIkgW+UdyQJ5XgKy/v+3LTViSQbN5Wh0OBgacSVHkI9TLfJUXyKzR0w/JFE9Uq 8Vs1b9gxhxzbBD0ozNd2O5rubbWFJ2pBLJlrW6NXFjRoL93+EniVf6YGOv4776W+AIQL z1ujpQAT8B2dmDmVFhq6NszbH+UvW4Vq53x8cPYGbwBzqIc4wBc0g0e2XBJQR87895ra fgtu3BPdmo856+wA2c/dn11eAdfsRaWzd7/cHjO4RKBuiwNI0/9sdqf3sKAxZfIR0MH9 zd8w== X-Gm-Message-State: AHQUAuaFofi/wnOwsHK5jPZ5NuXX5iytKTVrdURa7EHPJcj7G9HUWGGs ftP/CLXjDJ/300Ouck1PuKubAw== X-Google-Smtp-Source: AHgI3IZfXnbF4Wi7+502+k4ma2iHa5/MjJFK5csszlQgeORpYn/enXezvwbFsnRX/lZQaYNWNE4oOw== X-Received: by 2002:a7b:cf3a:: with SMTP id m26mr2126657wmg.144.1550568558567; Tue, 19 Feb 2019 01:29:18 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id c14sm19678773wrn.12.2019.02.19.01.29.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 01:29:17 -0800 (PST) Date: Tue, 19 Feb 2019 10:19:42 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink Message-ID: <20190219091942.GA3080@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-4-jakub.kicinski@netronome.com> <20190215101514.GD2343@nanopsycho> <20190215074429.6890e47e@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215074429.6890e47e@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicinski@netronome.com wrote: >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: >> > static const struct ethtool_ops nfp_net_ethtool_ops = { >> >> Why don't you use the compat fallback? I think you should. > >You and Michal both asked the same so let me answer the first to ask :) >- if devlink is built as a module the fallback is not reachable. So the fallback is not really good as you can't use it for real drivers anyway. Odd. Maybe we should compile devlink in without possibility to have it as module.