From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AF2C43381 for ; Tue, 19 Feb 2019 16:16:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71CBD2147A for ; Tue, 19 Feb 2019 16:16:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lz5Kwi6h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbfBSQQQ (ORCPT ); Tue, 19 Feb 2019 11:16:16 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:39292 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbfBSQQP (ORCPT ); Tue, 19 Feb 2019 11:16:15 -0500 Received: by mail-qk1-f193.google.com with SMTP id x6so12361373qki.6 for ; Tue, 19 Feb 2019 08:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=SuylGRXGCZsFdciXU9X6zJN78yCyTIE5VihsuFVwi0A=; b=lz5Kwi6hC0alCv/VBPNu0wNLRSKZnTJtpce/+rWmK0Hqj3ZCNoz7MVMWN+H4l5a3qJ 4TQ1NFRYijr2cFffXaTctsdIKeJ7xj1kdiGk5wrIM8u2Ax1I6wzDgpSF7GEeUyFn4TpV k6rBiwjtDqTRlz8ePPGTa788FITq6sFymMlRgt4NuVy3wFDvRbSq9Bvfiocl59nkA26K rtnjVxwXxFY0BagOaoZbiK+0vkFXlLr6vFyzcsQE6kmgSqXRloPE6FJInqTqagTCe85G b/5HNHbh3JGnKwfkv4UxuauelNklS/ULLGwPAfXtRTh8J7xnvTjCZRqlVVnuKsIt5TSa omRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=SuylGRXGCZsFdciXU9X6zJN78yCyTIE5VihsuFVwi0A=; b=plpJFYTPo0oGiTlNK9vkGRXZdxOEk0J1XUtbadXdglV8IfcNyNYkGUMSyCylN6H7lN cNynP6c/v/ne5vuk5Bom4FQDCATtMt1uPmEbcv9OgfMFCfCaAvHZTAYHtdTB9bO3zOTi hKyGr8JlhtN/49V8YfkXdMHsBY8HCn71vWJ9gf9K9owbwC4JHsqkCRzxEDJO5w0sA2sL bZMPMU8iJZXxPhEiHOCbltLZ+c0HPQiQgvJXbBl2TUCUcVUPo8BLBDR4srZV6t9moTwC si+Q7N5uVvZ/hu8elUZR9tQywnz1+JWz/pmKektPlUab17REank6hhodvyu+TEFcgsTg hvlQ== X-Gm-Message-State: AHQUAuZubSuSyZ3qEwbSuiByDRwY8U+khsfznsdeLmHy/dcokQc3Ehnj E6atyeP3gZn3pkNvrhfbvVw= X-Google-Smtp-Source: AHgI3IY/Pc0w3sXUs0nTJDFuusMf2+D+4nXRiyu8MgNKaBwNyldQ10liUBdQRtQB84TMqmDrhwhkgQ== X-Received: by 2002:ae9:f212:: with SMTP id m18mr20474276qkg.5.1550592974402; Tue, 19 Feb 2019 08:16:14 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 46sm12973210qty.59.2019.02.19.08.16.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 08:16:13 -0800 (PST) Date: Tue, 19 Feb 2019 11:16:12 -0500 Message-ID: <20190219111612.GF27578@t480s.localdomain> From: Vivien Didelot To: Russell King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags In-Reply-To: References: <20190217163114.yomawlljyxlqy3ob@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Russell, On Sun, 17 Feb 2019 16:32:34 +0000, Russell King wrote: > +static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port, > + unsigned long flags) > +{ > + struct mv88e6xxx_chip *chip = ds->priv; > + bool unicast, multicast; > + int ret = -EOPNOTSUPP; > + > + unicast = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port) || > + flags & BR_FLOOD; > + multicast = flags & BR_MCAST_FLOOD; > + > + mutex_lock(&chip->reg_lock); > + if (chip->info->ops->port_set_egress_floods) > + ret = chip->info->ops->port_set_egress_floods(chip, port, > + unicast, > + multicast); > + mutex_unlock(&chip->reg_lock); > + > + return ret; > +} > + > +static unsigned long mv88e6xxx_bridge_flags_support(struct dsa_switch *ds) > +{ > + struct mv88e6xxx_chip *chip = ds->priv; > + unsigned long support = 0; > + > + if (chip->info->ops->port_set_egress_floods) > + support |= BR_FLOOD | BR_MCAST_FLOOD; > + > + return support; > +} I think that it isn't necessary to propagate the notion of bridge flags down to the DSA drivers. It might be just enough to add: port_egress_flood(dsa_switch *ds, int port, bool uc, bool mc) to dsa_switch_ops and set BR_FLOOD | BR_MCAST_FLOOD from the DSA core, if the targeted driver has ds->ops->port_set_egress_flood. What do you think? Thanks, Vivien