From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B17BC43381 for ; Tue, 19 Feb 2019 14:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADEDA21773 for ; Tue, 19 Feb 2019 14:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="h2vLNAYr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbfBSOVs (ORCPT ); Tue, 19 Feb 2019 09:21:48 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:40716 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfBSOVs (ORCPT ); Tue, 19 Feb 2019 09:21:48 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1JEEaZd157626; Tue, 19 Feb 2019 14:21:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=rIY8OwkXY1p2HMhFKlJV1DQ4qDqcbHnIhhGq7Y4cXVY=; b=h2vLNAYrpzATKjjloTE7eS4WRdH+rgfSzBRrgoGkUaeut86XAWoelBSJxyrhId7l70zQ TY/dJbrNyZIyzXylnUfwH/ATFR8FHAfVIr3PKfItvDyX7DXJ2L18miQzHo9v7rnZFd+g /Dj2si1ReKkXOz063aR1tvWOAgz0KGNE4bClxToNNizAWLSABAcVr70BeY2qNhBE6Ylj IcZQLn0jxZamXrAjMrfubd66aLg04rcERDWlavXmhP1DBjVZf6lTy9bnMf9sZ9oZoNGL 2gQb2gBFCZTPCChgG306zGpKBzcImC61eANHT+YNFEtjVeKGMwC2NyWx6zJuqgfejMQa hg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2qp81e3ktc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 14:21:23 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1JELHcC029011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 14:21:17 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1JELHdj002876; Tue, 19 Feb 2019 14:21:17 GMT Received: from kadam (/197.157.0.53) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Feb 2019 06:21:16 -0800 Date: Tue, 19 Feb 2019 17:21:03 +0300 From: Dan Carpenter To: Mao Wenan Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org Subject: Re: [PATCH] net: ns83820: drop pointless static qualifier in ns83820_probe_phy() Message-ID: <20190219142103.GH17104@kadam> References: <20190219080659.89732-1-maowenan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219080659.89732-1-maowenan@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=814 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902190107 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Just delete it instead. regards, dan carpenter