From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 007E1C43381 for ; Tue, 19 Feb 2019 19:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD50C21479 for ; Tue, 19 Feb 2019 19:56:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PzVWhlrL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbfBST4h (ORCPT ); Tue, 19 Feb 2019 14:56:37 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:39660 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbfBST4f (ORCPT ); Tue, 19 Feb 2019 14:56:35 -0500 Received: by mail-qk1-f195.google.com with SMTP id x6so464552qki.6 for ; Tue, 19 Feb 2019 11:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=8WTiYMQCLjpT5zFBPe3YlDGrXHd0O68+rdIJjojdAhE=; b=PzVWhlrLFeDvfsZ2VUP7PrJLk6gvkglKbRRli99PQC9kuVHCnX0eyFRG47y0sqXcKw zrSrDjx07KCbFvT4safr2BnwMFnhfadJHPzOmbPANEadJ/Doqh/Urvjsx83ai6H3po/V qW8HLm2agssTszkKJ4e7ceNYahutQVsZQo1tNp2I00UoLYuEBVKG10p0/CHpgNspwzPr J2a/RGV+MS6DmByo6gSEvpENCAa24JhvbbDJ/N+J/VOgcsrYwdux6E63elr+41ekvS3k o7hrOHMW6FPCtBrmZ7T8aFbTlzU726mr6GXWtMwXwnY4bUY+17Htw+cgpntXZB5JAaAd 2RFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=8WTiYMQCLjpT5zFBPe3YlDGrXHd0O68+rdIJjojdAhE=; b=Qq2lXsp0t5TViBP4zK0/+AH5UnQRGH/ygJc0U/xlLNCFBa2BhougBWDB0S2DvX3ohG vaL8MsTPkaPX4ZAK8tSU7ulqszIMF4Maw6VuVQWQd87AtgoE8WFAUEuilXmV44YtpkXD CNu7qP/lh0aUnQCoUpYFOHN449PsR5m5maMRfKV62f8pCVw/ydVilvCpxMRUogyS4aNp yJ+lXSBRlymV7QBlSZZB9/kP1z1OBOH0jqn9QzB7RkXQTaC768FmtbP5xcjvxjgVR6pM vjXiG+KDN4/Lavfln5ETiRP7/Wgo8xwx/7IOeHPfGBm3/K9/f4Npo5A2jJqola0kEjlG m4sw== X-Gm-Message-State: AHQUAuamqmnZ3CXPZjThKjvQ34Rxkz5BMqcLjMdiDb7voIZNKW4y+UuB MND93iAVTcZKWWK1ORvxGE4= X-Google-Smtp-Source: AHgI3IZQnfX3DgydSHVC+iMoLoT1+XFwJrDjYvt+HtViAABdvT5K12TQ2uLB2wNWD3q8JgZClAT2oA== X-Received: by 2002:a37:85c7:: with SMTP id h190mr21612397qkd.225.1550606189441; Tue, 19 Feb 2019 11:56:29 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id s19sm1359446qth.80.2019.02.19.11.56.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 11:56:28 -0800 (PST) Date: Tue, 19 Feb 2019 14:56:27 -0500 Message-ID: <20190219145627.GB27596@t480s.localdomain> From: Vivien Didelot To: Russell King - ARM Linux admin Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags In-Reply-To: <20190219191016.u65vvw5y3iydt5zx@shell.armlinux.org.uk> References: <20190217163114.yomawlljyxlqy3ob@shell.armlinux.org.uk> <20190219111612.GF27578@t480s.localdomain> <20190219162435.f5zl5harbarwy6bj@shell.armlinux.org.uk> <20190219120000.GB4140@t480s.localdomain> <20190219171414.cvaiw7u2xnd5zk3g@shell.armlinux.org.uk> <20190219123828.GD10959@t480s.localdomain> <20190219180811.qxsu2ss3g7jwhgfb@shell.armlinux.org.uk> <20190219140444.GD16594@t480s.localdomain> <20190219191016.u65vvw5y3iydt5zx@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Russell, On Tue, 19 Feb 2019 19:10:16 +0000, Russell King - ARM Linux admin wrote: > > True, let's stick with ops->port_egress_flood(ds, port, bool uc, bool mc). > > I do not think that it is necessary to add support for BR_BCAST_FLOOD yet, > > we can extend this routine later if we need to. > > > > Your dsa_port_bridge_flags() core function can notify the understood > > features. This will allow us to scope the support of the bridge flags in > > the core, and preventing the drivers to do that themselves. > > So, if we have ops->port_egress_flood, then we tell bridge that > we support BR_FLOOD | BR_MCAST_FLOOD, irrespective of whether the > bridge actually supports both? I would say so yes. If a driver implements port_egress_flood(), this means its switch device supports both BR_FLOOD | BR_MCAST_FLOOD. I have one concern though. The documentation of mcast_flood for bridge(8) says that this flag "controls whether a given port will *be flooded* with [unknown] multicast traffic". From this I understand allowing this port to *receive* frames with unknown destination addresses. But with mv88e6xxx, we program whether the port is allowed to egress a frame that has an unknown destination address. Otherwise, it will not go out this port. Am I mistaken? If I understood correctly, is it safe to assume it is the same thing we are implementing here? Thanks, Vivien