From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B039C43381 for ; Tue, 19 Feb 2019 23:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E93B21736 for ; Tue, 19 Feb 2019 23:22:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="X/BRcip1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728290AbfBSXWK (ORCPT ); Tue, 19 Feb 2019 18:22:10 -0500 Received: from mail-pl1-f181.google.com ([209.85.214.181]:36374 "EHLO mail-pl1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbfBSXWK (ORCPT ); Tue, 19 Feb 2019 18:22:10 -0500 Received: by mail-pl1-f181.google.com with SMTP id k2so1828479plt.3 for ; Tue, 19 Feb 2019 15:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SQhwy1CLqgPx/yNF4Q1FtVgtYEio/WPZA8O1laUWay4=; b=X/BRcip1a6fbV72z3Mh5wVOzUpz9PwWY8GyPJ91p96lQDeWuExF0J4La/Fpz+MRd96 +6zec80wIhqMYqsepRwMM6yg4ov5jHrK41nhI9/BE+6X2mteLaoz2TFjJE3VnP5J15fv qi4krL6e1bJGC3yaVFvuTQY9tgDBlpTITOmsfE7x78kMV4cEG238O+/ZhdmOaT8CmiJ+ aFFzD5LEEW5KGoBfHuFHW6rhfX+LcK1TqpTHPkYi9tZZRXGGfD1sehcVUNiMEYoIjQrO PDL4ynJt75ie/wofD41nAOC5kSJhnA3F0j2cQuy3arljQ0ZTP+/FC7dGT+iCdXKFS6EC 2pZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SQhwy1CLqgPx/yNF4Q1FtVgtYEio/WPZA8O1laUWay4=; b=a8QjKD8X8hSxG5UtR5fSNzDu9IqeDD4C+TaDHLT2SkSpxM7WEDFn2cHba6R9LQvxTc XqthDQBPhvMvh7/cORHx2EHQL/SnqWXQUFEpVEUNN7gcVEGEXAa5+EVgKmBSNJXUhIaF z8vfsYo1Z7SU9TXdDQdcz8jwLRPlmiECFoJ13TEJElpZYho6DkxVNSVL6vYm+h2cTHv/ a2W3+IrerNvPrOSLmj7GWXaxUe/dJmz3r65zvmf3DBozpYdjMtSMM1hsJ0WJdN/DrQP6 1TPxsoQP8oxfe+uTU8zfYqAjqZLdlkqDc2CxF4RywhqP6H281BcC9koEk75NPcVv84RJ 6xJA== X-Gm-Message-State: AHQUAuYdyq2/sU9Ct0clOFkkGegwEM/9EmhQ4051fsyizV9r8d5Q+jjA FNP5UYgVM8WPDPkVp/2pphjlAA== X-Google-Smtp-Source: AHgI3IbGoKGNN3mJM80Cn+6DdGVmU9jnLPue4ryQb1qgPFn7TAGjZk0c1jjFuhJobXayUwK/dfi0WA== X-Received: by 2002:a17:902:c05:: with SMTP id 5mr33733225pls.155.1550618529568; Tue, 19 Feb 2019 15:22:09 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e6sm33667085pfe.59.2019.02.19.15.22.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 15:22:09 -0800 (PST) Date: Tue, 19 Feb 2019 15:22:06 -0800 From: Stephen Hemminger To: Thomas Haller Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2, v2] ip-rule: fix json key "to_tbl" for unspecific rule action Message-ID: <20190219152206.7d79da00@shemminger-XPS-13-9360> In-Reply-To: <20190219205019.30757-1-thaller@redhat.com> References: <20190219101958.5c4bbd0d@shemminger-XPS-13-9360> <20190219205019.30757-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Feb 2019 21:50:19 +0100 Thomas Haller wrote: > The key should not be called "to_tbl" because it is exactly > not a FR_ACT_TO_TBL action. Change it to "action". > > # ip rule add blackhole > # ip -j rule | python -m json.tool > ... > { > "priority": 0, > "src": "all", > "to_tbl": "blackhole" > }, > > This is an API break of JSON output as it was added in v4.17.0. > Still change it as the API is relatively new and unstable. > > Fixes: 0dd4ccc56c0e ("iprule: add json support") > > Signed-off-by: Thomas Haller Applied, thanks.