From: Stephen Hemminger <stephen@networkplumber.org>
To: Luca Boccassi <bluca@debian.org>
Cc: netdev@vger.kernel.org, "Clément Hertling" <wxcafe@wxcafe.net>
Subject: Re: [RFC iproute2 v2] ip route: get: allow zero-length subnet mask
Date: Tue, 19 Feb 2019 15:22:38 -0800 [thread overview]
Message-ID: <20190219152238.05298fc2@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190214232918.6185-1-bluca@debian.org>
On Thu, 14 Feb 2019 23:29:18 +0000
Luca Boccassi <bluca@debian.org> wrote:
> A /0 subnet mask is theoretically valid, but ip route get doesn't allow
> it:
>
> $ ip route get 1.0.0.0/0
> need at least a destination address
>
> Change the check and remember whether we found an address or not, since
> according to the documentation it's a mandatory parameter.
>
> $ ip/ip route get 1.0.0.0/0
> 1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
> cache
>
> Reported-by: Clément Hertling <wxcafe@wxcafe.net>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
Applied
prev parent reply other threads:[~2019-02-19 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 20:09 [RFC iproute2] ip route: get: allow zero-length subnet mask Luca Boccassi
2019-02-13 20:37 ` Stephen Hemminger
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
2019-02-19 23:22 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219152238.05298fc2@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=wxcafe@wxcafe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox