From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA19C43381 for ; Tue, 19 Feb 2019 16:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86FE62147A for ; Tue, 19 Feb 2019 16:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="uAQl0Uak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbfBSQJi (ORCPT ); Tue, 19 Feb 2019 11:09:38 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56044 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbfBSQJi (ORCPT ); Tue, 19 Feb 2019 11:09:38 -0500 Received: by mail-wm1-f68.google.com with SMTP id q187so3425184wme.5 for ; Tue, 19 Feb 2019 08:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rZJsn4wkDGVu0k/rU/87fNY1ui/U1XXy6Bn+UmOADSo=; b=uAQl0UakkmPWaEy9LpyZ6XKY9phnzE3Y/jMWZtKG400hPmr0WZoimHnfSSk+OQn229 IwMw02zTtKiR2w3ksFNbw+4rK5H1jKRkGteX0tl1TyreTb+v0a2yr9LOtDBZDpkQVYB0 XHWYfL2npOFtikLX7JKGpidqSVVEzz9J26NfFUzVv3xiGoEepQ+C1rndqIv075qj+02G I827rBGeIlxOagcIUO/O7QTPKxpokrQzb5LK1tIPyKEK4ufycvVkjRFZu5q7/nLZfhVT iJYR5QYw6zyXvNmj9kRZd9emUNN7HZpgdVxUi3KopPQb/vMeG0ZjRoCNxaRF4LOLwGWk B4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rZJsn4wkDGVu0k/rU/87fNY1ui/U1XXy6Bn+UmOADSo=; b=oBgdka/BqymAdye2zI6VQQdn9KYOAPL7BixX9ViEsmaVzf0Rnw5W8NmAdbMyzKks+h mak+0rKFs0IoTrNr+rbyMD8BJwGWkvK3fTj1NaRU7C9fJuMLGsLTkiZCRxDQXGwSVOq7 DgNwcKmsw2UZXSXlEc/nbFH3TP7oY3nCTPAGn2LFO7Gv38r4Z5Ko4dUJRM/edy88Vvcn EDgrL0RJsTAF8TOTlnt/YB6v1E809UTDBsA36o00vmPvAs7keoqhtq9WQKaiV5R/KkMi CtHRZ6ueXjXraHq1VbRHJt/875i5vP0TI8PZZ3V2FyFqgxaLdyEn70CtEaJjrI7rB/mL KMxQ== X-Gm-Message-State: AHQUAuZTyF4whReW7uCJwx1A4OG77mNyNdD83E7+XGQNuvPzANBWgRuG sekK3mKi2VAYS/UwA3NdZhZwlFKgZro= X-Google-Smtp-Source: AHgI3IbNwlT5OVZi/rhEVvpyZcwi1OsSqi2JrpBkgezvwKtwB32bNciEqBVJEGBnKrT96PcFOjtWEQ== X-Received: by 2002:a7b:cc93:: with SMTP id p19mr3426694wma.113.1550592576247; Tue, 19 Feb 2019 08:09:36 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id u134sm3386276wmf.21.2019.02.19.08.09.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 08:09:35 -0800 (PST) Date: Tue, 19 Feb 2019 17:00:00 +0100 From: Jiri Pirko To: George Wilkie Cc: "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net] team: use operstate consistently for linkup Message-ID: <20190219160000.GG3080@nanopsycho> References: <20190219155715.769-1-gwilkie@vyatta.att-mail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219155715.769-1-gwilkie@vyatta.att-mail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 19, 2019 at 04:57:15PM CET, gwilkie@vyatta.att-mail.com wrote: >When a port is added to a team, its initial state is derived >from netif_carrier_ok rather than netif_oper_up. >If it is carrier up but operationally down at the time of being >added, the port state.linkup will be set prematurely. >port state.linkup should be set consistently using >netif_oper_up rather than netif_carrier_ok. > >Fixes: f1d22a1e0595 ("team: account for oper state") > >Signed-off-by: George Wilkie Acked-by: Jiri Pirko