From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46085C43381 for ; Wed, 20 Feb 2019 00:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 023A22147A for ; Wed, 20 Feb 2019 00:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="r1h+SAA2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728290AbfBTAtf (ORCPT ); Tue, 19 Feb 2019 19:49:35 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:40972 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbfBTAtf (ORCPT ); Tue, 19 Feb 2019 19:49:35 -0500 Received: by mail-qt1-f194.google.com with SMTP id v10so25480946qtp.8 for ; Tue, 19 Feb 2019 16:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=N7javHGjJUXDiP/2SC0ZW74Pgeak9kU9rF8x1YLq520=; b=r1h+SAA2jDdPTrMHNbA3fgmG80vFfccwcCIIdHyzZAq2bGr/JKcbbNQmCN1cOUTTBe a0+nLhLEmHgQssbZcDAQzqOQkBs2LzALSQENCKy5RbsrD2NSmcsiiFZB58ewtvSKTams NmnAUgvoyzQEfw8G4tSWVjXoOGRc/I+gZAs1bpvXDOjqGCHZzIIBygP7U2z82B7EZIXm 4TxBDlXz/9fuY6JnrupTMlU5Z11n6iAxi4h97thkFZ5rb3QrSvjDZqsNkeZ//K427q7/ 1cyarPLZ7z8IgSSZgJ2YjZAXC6REa03lZN8+BwvZCkRc5e1e96GAnEru6S6n6s2B2UR/ /ANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=N7javHGjJUXDiP/2SC0ZW74Pgeak9kU9rF8x1YLq520=; b=f2dE91DICgusASFbiAtxcWpKqw7Aq9fvmAtOqwKITTySo3Y/jJSmq4O2n2FzAjId9k cpkdvw2oCduYbGpuPdOF036BYKkC0nOe7u54z7oJyfp1f0NOXO7Td9acUvVa5iR0MR2P sAjWIHtAqJuIYlZVX/mnYirnuXzicFi3JOJ9QS5W2prk9wE8/6W64xlRfdgqVkq9h7TT 2uVZzPzowEcU9EeQZQuRLjW2z9iG1e6P5E79m7yVy+lR6AutPEGvfS7czB7nSNFCf2jK Y/WBgOeRXKHvuYZf/KjCoK/Yq1xrHPEZHWGwI3/xJrlKe66ct2TENeRbdXJAKk5PS4PT Zdaw== X-Gm-Message-State: AHQUAuacf49q4R+S12Kq2yAgVYbWziFgxjVRsdOmYe/+xSCzyYYMf60e 5Uab8+jfi1BHq9sKwNDdhRSdqQD2550= X-Google-Smtp-Source: AHgI3IZl5dMDFSQFJavE1Zmp46bQb0xlDRZh/QXTP1jTZWgcIssFZPALo6sSKT2UULQBsFd1+Q7FkQ== X-Received: by 2002:ac8:969:: with SMTP id z38mr25300840qth.49.1550623774829; Tue, 19 Feb 2019 16:49:34 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y11sm17124526qky.2.2019.02.19.16.49.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Feb 2019 16:49:34 -0800 (PST) Date: Tue, 19 Feb 2019 16:49:26 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink Message-ID: <20190219164926.23981359@cakuba.netronome.com> In-Reply-To: <20190219091942.GA3080@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-4-jakub.kicinski@netronome.com> <20190215101514.GD2343@nanopsycho> <20190215074429.6890e47e@cakuba.netronome.com> <20190219091942.GA3080@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote: > Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicinski@netronome.com wrote: > >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: > >> > static const struct ethtool_ops nfp_net_ethtool_ops = { > >> > >> Why don't you use the compat fallback? I think you should. > > > >You and Michal both asked the same so let me answer the first to ask :) > >- if devlink is built as a module the fallback is not reachable. > > So the fallback is not really good as you can't use it for real drivers > anyway. Odd. Maybe we should compile devlink in without possibility to > have it as module. Ack, I'll make devlink a bool. I need a little extra time, I forgot that nfp's flower offload still doesn't register all ports (using your port flavour infrastructure).