From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA311C43381 for ; Tue, 19 Feb 2019 15:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA8832146E for ; Tue, 19 Feb 2019 15:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729094AbfBSP5t (ORCPT ); Tue, 19 Feb 2019 10:57:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729018AbfBSP5t (ORCPT ); Tue, 19 Feb 2019 10:57:49 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BFC8787621; Tue, 19 Feb 2019 15:57:48 +0000 (UTC) Received: from carbon (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id A93A95F9D0; Tue, 19 Feb 2019 15:57:46 +0000 (UTC) Date: Tue, 19 Feb 2019 16:57:45 +0100 From: Jesper Dangaard Brouer To: Daniel Borkmann Cc: netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , brouer@redhat.com Subject: Re: [PATCH bpf-next] bpf: add skb->queue_mapping write access from tc clsact Message-ID: <20190219165745.676097a3@carbon> In-Reply-To: <11d2572e-3ff5-2fc0-8f05-c50dd0fb1d6d@iogearbox.net> References: <155057184028.20935.11848804617158437103.stgit@firesoul> <11d2572e-3ff5-2fc0-8f05-c50dd0fb1d6d@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 19 Feb 2019 15:57:48 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Feb 2019 12:46:57 +0100 Daniel Borkmann wrote: > > Due to lack of TC examples, lets show howto attach clsact BPF programs: > > > > # tc qdisc add dev ixgbe2 clsact > > # tc filter replace dev ixgbe2 egress bpf da obj XXX_kern.o sec tc_qmap2cpu > > # tc filter list dev ixgbe2 egress Recommending the "replace" is wrong is seems, as does not replace the existing, but keeps adding more filter entries. What is the recommended procedure for unloading and loading a newer version of the BPF TC program? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer