From: Guillaume Nault <gnault@redhat.com>
To: James Chapman <jchapman@katalix.com>
Cc: t.martitz@avm.de, davem@davemloft.net, netdev <netdev@vger.kernel.org>
Subject: Re: L2TPv3 offset
Date: Tue, 19 Feb 2019 18:54:35 +0100 [thread overview]
Message-ID: <20190219175434.GA31500@pc-2.home> (raw)
In-Reply-To: <e685d22c-e28e-8318-f612-07e2d1cd03ab@katalix.com>
On Tue, Feb 19, 2019 at 04:36:55PM +0000, James Chapman wrote:
> On 19/02/2019 13:09, t.martitz@avm.de wrote:
> >
> > Because everytime a LCCE decapsulates such traffic it'll suffer from
> > unaligned access to the inner IP header (likewise for the outer IP
> > header when encapsulating). It's a fundamental assumption that the IP
> > header is word-aligned in Linux so I'm surprised this isn't solved
> > already. And now the only way "fix" without patching the kernel is
> > being removed.
> >
IIUC, you'd be perfectly fine running without offset if the stack was
properly handling the alignment problems created by the encapsulated
ethernet header.
Unaligned headers is a fundamental problem when tunneling ethernet
frames. I'd expect other encapsulation modules (vxlan, geneve,
gretap...) to have the same issues (but I'd be happy to be proven
wrong).
The topic has been discussed a few years ago:
https://lore.kernel.org/netdev/20160922.015242.735026657310158125.davem@davemloft.net/
I might very well have missed some discussions, but I don't remember
any patch aimed at tackling this problem so far.
prev parent reply other threads:[~2019-02-19 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF967393CB.A0BF4494-ONC12583A6.00323DFC-C12583A6.00330730@avm.de>
2019-02-19 12:40 ` L2TPv3 offset James Chapman
[not found] ` <OFF1459E30.8430BF87-ONC12583A6.0047B081-C12583A6.004841EE@avm.de>
2019-02-19 16:36 ` James Chapman
2019-02-19 17:54 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219175434.GA31500@pc-2.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=t.martitz@avm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).