From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBF5C43381 for ; Wed, 20 Feb 2019 19:25:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C89321841 for ; Wed, 20 Feb 2019 19:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbfBTTZC (ORCPT ); Wed, 20 Feb 2019 14:25:02 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:54940 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfBTTZC (ORCPT ); Wed, 20 Feb 2019 14:25:02 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B1370121605CA; Wed, 20 Feb 2019 11:25:01 -0800 (PST) Date: Wed, 20 Feb 2019 11:25:01 -0800 (PST) Message-Id: <20190220.112501.238057192324769522.davem@davemloft.net> To: willemdebruijn.kernel@gmail.com Cc: netdev@vger.kernel.org, willemb@google.com Subject: Re: [PATCH net-next] gso: validate gso_type on ipip style tunnels From: David Miller In-Reply-To: <20190220155212.47248-1-willemdebruijn.kernel@gmail.com> References: <20190220155212.47248-1-willemdebruijn.kernel@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Feb 2019 11:25:01 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Willem de Bruijn Date: Wed, 20 Feb 2019 10:52:12 -0500 > From: Willem de Bruijn > > Commit 121d57af308d ("gso: validate gso_type in GSO handlers") added > gso_type validation to existing gso_segment callback functions, to > filter out illegal and potentially dangerous SKB_GSO_DODGY packets. > > Convert tunnels that now call inet_gso_segment and ipv6_gso_segment > directly to have their own callbacks and extend validation to these. > > Signed-off-by: Willem de Bruijn Looks good, applied, thanks Willem.