From: David Miller <davem@davemloft.net>
To: rmk+kernel@armlinux.org.uk
Cc: thomas.petazzoni@bootlin.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: marvell: mvneta: fix DMA debug warning
Date: Wed, 20 Feb 2019 19:57:12 -0800 (PST) [thread overview]
Message-ID: <20190220.195712.291935128844235315.davem@davemloft.net> (raw)
In-Reply-To: <E1gudxz-0001T0-0K@rmk-PC.armlinux.org.uk>
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Fri, 15 Feb 2019 13:55:47 +0000
> Booting 4.20 on SolidRun Clearfog issues this warning with DMA API
> debug enabled:
...
> This appears to be caused by mvneta_rx_hwbm() calling
> dma_sync_single_range_for_cpu() with the wrong struct device pointer,
> as the buffer manager device pointer is used to map and unmap the
> buffer. Fix this.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> Please check that this is the correct fix.
This makes it consistent with the other DMA calls in the hwbm
code paths, so on that basis I'm applying this and queueing it
up for -stable.
Thanks.
prev parent reply other threads:[~2019-02-21 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 13:55 [PATCH] net: marvell: mvneta: fix DMA debug warning Russell King
2019-02-15 14:31 ` Gregory CLEMENT
2019-02-15 17:05 ` Russell King - ARM Linux admin
2019-02-21 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220.195712.291935128844235315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).