From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04E2C43381 for ; Thu, 21 Feb 2019 03:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCAEA2086C for ; Thu, 21 Feb 2019 03:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726359AbfBUD5N (ORCPT ); Wed, 20 Feb 2019 22:57:13 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:59958 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfBUD5N (ORCPT ); Wed, 20 Feb 2019 22:57:13 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CBE1412F7A9FF; Wed, 20 Feb 2019 19:57:12 -0800 (PST) Date: Wed, 20 Feb 2019 19:57:12 -0800 (PST) Message-Id: <20190220.195712.291935128844235315.davem@davemloft.net> To: rmk+kernel@armlinux.org.uk Cc: thomas.petazzoni@bootlin.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: marvell: mvneta: fix DMA debug warning From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Feb 2019 19:57:13 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Russell King Date: Fri, 15 Feb 2019 13:55:47 +0000 > Booting 4.20 on SolidRun Clearfog issues this warning with DMA API > debug enabled: ... > This appears to be caused by mvneta_rx_hwbm() calling > dma_sync_single_range_for_cpu() with the wrong struct device pointer, > as the buffer manager device pointer is used to map and unmap the > buffer. Fix this. > > Signed-off-by: Russell King > --- > Please check that this is the correct fix. This makes it consistent with the other DMA calls in the hwbm code paths, so on that basis I'm applying this and queueing it up for -stable. Thanks.