From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C99AC43381 for ; Thu, 21 Feb 2019 04:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2D352147A for ; Thu, 21 Feb 2019 04:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbfBUEL7 (ORCPT ); Wed, 20 Feb 2019 23:11:59 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:60088 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbfBUEL6 (ORCPT ); Wed, 20 Feb 2019 23:11:58 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 547EA108F879B; Wed, 20 Feb 2019 20:11:58 -0800 (PST) Date: Wed, 20 Feb 2019 20:11:57 -0800 (PST) Message-Id: <20190220.201157.306268622139550136.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us Subject: Re: [Patch net-next 2/2] net_sched: fix a memory leak in cls_tcindex From: David Miller In-Reply-To: <20190216185827.21535-2-xiyou.wangcong@gmail.com> References: <20190216185827.21535-1-xiyou.wangcong@gmail.com> <20190216185827.21535-2-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Feb 2019 20:11:58 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Sat, 16 Feb 2019 10:58:27 -0800 > (cherry picked from commit 033b228e7f26b29ae37f8bfa1bc6b209a5365e9f) > > When tcindex_destroy() destroys all the filter results in > the perfect hash table, it invokes the walker to delete > each of them. However, results with class==0 are skipped > in either tcindex_walk() or tcindex_delete(), which causes > a memory leak reported by kmemleak. > > This patch fixes it by skipping the walker and directly > deleting these filter results so we don't miss any filter > result. > > As a result of this change, we have to initialize exts->net > properly in tcindex_alloc_perfect_hash(). For net-next, we > need to consider whether we should initialize ->net in > tcf_exts_init() instead, before that just directly test > CONFIG_NET_CLS_ACT=y. > > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Signed-off-by: Cong Wang Applied.