From: Stanislav Fomichev <sdf@fomichev.me>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: brakmo <brakmo@fb.com>, netdev <netdev@vger.kernel.org>,
Martin Lau <kafai@fb.com>, Alexei Starovoitov <ast@fb.com>,
daniel@iogearbox.net
Subject: Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs
Date: Tue, 19 Feb 2019 21:01:29 -0800 [thread overview]
Message-ID: <20190220050129.GC1928@mini-arch> (raw)
In-Reply-To: <20190219181435.1c5c6375@cakuba.netronome.com>
On 02/19, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote:
> > +#include "bpf_load.h"
>
> nit: please use libbpf
My suggestion was to just use bpftool, no need for another helper in the
samples/ directory. WDYT?
next prev parent reply other threads:[~2019-02-20 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 5:38 [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs brakmo
2019-02-20 2:14 ` Jakub Kicinski
2019-02-20 5:01 ` Stanislav Fomichev [this message]
2019-02-20 18:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220050129.GC1928@mini-arch \
--to=sdf@fomichev.me \
--cc=ast@fb.com \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).