From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB510C43381 for ; Wed, 20 Feb 2019 08:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4D4C2146E for ; Wed, 20 Feb 2019 08:47:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="JHCZ48mF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726030AbfBTIr0 (ORCPT ); Wed, 20 Feb 2019 03:47:26 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54434 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbfBTIr0 (ORCPT ); Wed, 20 Feb 2019 03:47:26 -0500 Received: by mail-wm1-f66.google.com with SMTP id a62so5698205wmh.4 for ; Wed, 20 Feb 2019 00:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qZkmZlj/+GHlMYeY6WbOFVLzyV9l9nMYcYOQ9DTItq4=; b=JHCZ48mF+OhbAixspSN7pjfQJaADkJgvx9HWihFjswUGwevgt4wH3TL4tHeeySz4Hj pL4d2Tk9NUCWBQk3msK6BzmPj+HO6J2UairP4DHCtXCFrUBBpcz5GIn2iLV29dsbRg7p bs7Pe9pSP31WDPiOdHf+DOQJrPoUY+SJUuPoM5yuP5HbPLe9LM2LAl/n9KXChT3pcnRh oAncaPhMrpaYSmVt3NAB4yu3ejFqzx5QJ9bxju4OHgaQiNfIRXnHsWpaAB8N9ma2FuHp DjpTZxYTT8XFNXgvN6TVg//R5hdl87xETNu1S3pO5HV5eoyKBK/HrCtUtHcHXoVmsQ1F MkGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qZkmZlj/+GHlMYeY6WbOFVLzyV9l9nMYcYOQ9DTItq4=; b=Y1QsqHn7eVo91FdIWfyJH668ngbNCvUQ48nyh0ln+bzRS2Lm1zEhkv1pG++p9tFqON WUnj/7EkK1DG9zu6Njm4wUnzxnTFL0vcfpPH8RPrnf+UvFmjaQGF+pmHmlm84PzME+Iz BK9459aSMe9XZ/vkPvsam1+8gLdBnsbgHze4UuOTy8pkC/7pF6MiG7df4AN1qs+MD9qF yG3GTuoSjRyROec3mQ+gYa2T9ybkhUhKpKwRP+D1TTIzaP/HSed4Qry4xr/1nXxrCqYq WbQXaJlxcTJtZNhkOo4z2RmFJddtmJeEjSeiz5XLZKX7uxVyyvQiSg3a4+tzZ6I4q4Dq cAnQ== X-Gm-Message-State: AHQUAubBRQ3eu5PSbf6ki5nfTEcsaSezWHiMJsNzOWisgjquMOp+xRFE w7M2yLaY8SVDcMw3jJ9NQOFzSA== X-Google-Smtp-Source: AHgI3IYWOjz8Kt3c5ycd9OnABViUurJRWBmHiYH6agrOYoe+xHgfbFaXHPBDC625zYACoJUpYnOQ1A== X-Received: by 2002:a1c:1b4e:: with SMTP id b75mr6078949wmb.88.1550652443972; Wed, 20 Feb 2019 00:47:23 -0800 (PST) Received: from localhost (ip-213-220-234-21.net.upcbroadband.cz. [213.220.234.21]) by smtp.gmail.com with ESMTPSA id p5sm3123268wmh.16.2019.02.20.00.47.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 00:47:23 -0800 (PST) Date: Wed, 20 Feb 2019 09:37:49 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com, mkubecek@suse.cz, andrew@lunn.ch Subject: Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink Message-ID: <20190220083749.GL3080@nanopsycho> References: <20190214214046.19182-1-jakub.kicinski@netronome.com> <20190214214046.19182-4-jakub.kicinski@netronome.com> <20190215101514.GD2343@nanopsycho> <20190215074429.6890e47e@cakuba.netronome.com> <20190219091942.GA3080@nanopsycho> <20190219164926.23981359@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219164926.23981359@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 20, 2019 at 01:49:26AM CET, jakub.kicinski@netronome.com wrote: >On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote: >> Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicinski@netronome.com wrote: >> >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: >> >> > static const struct ethtool_ops nfp_net_ethtool_ops = { >> >> >> >> Why don't you use the compat fallback? I think you should. >> > >> >You and Michal both asked the same so let me answer the first to ask :) >> >- if devlink is built as a module the fallback is not reachable. >> >> So the fallback is not really good as you can't use it for real drivers >> anyway. Odd. Maybe we should compile devlink in without possibility to >> have it as module. > >Ack, I'll make devlink a bool. Thanks! > >I need a little extra time, I forgot that nfp's flower offload still >doesn't register all ports (using your port flavour infrastructure). Finally :)