From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2F3C43381 for ; Wed, 20 Feb 2019 18:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A606620645 for ; Wed, 20 Feb 2019 18:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="2JI0ZS7r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726120AbfBTSnn (ORCPT ); Wed, 20 Feb 2019 13:43:43 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37742 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfBTSnn (ORCPT ); Wed, 20 Feb 2019 13:43:43 -0500 Received: by mail-qk1-f196.google.com with SMTP id m9so2653166qkl.4 for ; Wed, 20 Feb 2019 10:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=8gc4DHsWMlVtcwQ3hb4NtrmkyvABnuUAztsp0DS9ooY=; b=2JI0ZS7rLY4u8DBWvG+Jq9lhMwCHPwWqVRUAME90tHHnehFJ3v9UkjJdy5nL4L8uaw 8DjriwDhPDkemeLNML4SFut2AsNIrYxt0eaNgPg9+NZQ5XDH7jbT5S5yp9kmC77++5Wu Ykd8rO7tOruAAisF/ANIvAWY+pfY7mbzOmqCBORpmH32uCTMDPsRjbGocxLUQ4ufZGCi sF6lbTpRoVK7dqNTBvDUbDNMTeN4yMAnclladU7gI3fdMLbcBMBlVZCUpI06VwXuBgXM 6xP9sW70Jxc32NmmQ9jJv8BictunWp0sreDWh1nXKwVgFGqIc8lcUgliCb1QdEL0WsKD +HWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=8gc4DHsWMlVtcwQ3hb4NtrmkyvABnuUAztsp0DS9ooY=; b=kdh2jxI0wu5pMTJYPEbxUTRgWJQQLWu38rGDkxrHPEouMubCpiVZuF0rUgcLxILWkN VxFBIDF12gJM6z/8V80osAknrUwaA5huU4yOxf1DZPhxzEQUBQ/An35qeMGJlIY1+UuB 1n1wat3OUI7le8w6N47tRa9nSIaxW1RVJcRYYnRRhnnRRBYvoxI4Bl+CrbtzT/H2GZYR c1tbHvUnDJoJ5FU9xXMieXF6e3b13GgYpRZYSBiUO0/No68OiZHuA92cncp9xWkWSQc8 i8rBMN8rove1UhiVeLy3wWNUwmPa4ct+YxehLkl8wlRqpYjC0SMCUGQForjSmnlAzK6Y pf1Q== X-Gm-Message-State: AHQUAuYO8jwQJ6KrTQBtMsmkSqX5ZytxBntadbhOkaDy5OPzO9ow6B0r 12J6Nwqxte8mnVECBsIGw15+kQ== X-Google-Smtp-Source: AHgI3IbQX8mqYdlLzglCDssLaAZb4F+2FgEiiVcKtTmWur7rbWtwaGdQBjkc/qURnaRjmy4kCU2RWw== X-Received: by 2002:a05:620a:123b:: with SMTP id v27mr24473315qkj.29.1550688222519; Wed, 20 Feb 2019 10:43:42 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t38sm19188786qtc.12.2019.02.20.10.43.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 10:43:42 -0800 (PST) Date: Wed, 20 Feb 2019 10:43:37 -0800 From: Jakub Kicinski To: Stanislav Fomichev Cc: brakmo , netdev , Martin Lau , Alexei Starovoitov , daniel@iogearbox.net Subject: Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs Message-ID: <20190220104337.37891c49@cakuba.netronome.com> In-Reply-To: <20190220050129.GC1928@mini-arch> References: <20190219053836.2086878-1-brakmo@fb.com> <20190219181435.1c5c6375@cakuba.netronome.com> <20190220050129.GC1928@mini-arch> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 19 Feb 2019 21:01:29 -0800, Stanislav Fomichev wrote: > On 02/19, Jakub Kicinski wrote: > > On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > > > +#include "bpf_load.h" > > > > nit: please use libbpf > My suggestion was to just use bpftool, no need for another helper in the > samples/ directory. WDYT? Oh yes, you're right, bpftool fully covers what this samples does.