From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73919C43381 for ; Wed, 20 Feb 2019 16:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 448B42084D for ; Wed, 20 Feb 2019 16:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="aY/F54Td" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726192AbfBTQuO (ORCPT ); Wed, 20 Feb 2019 11:50:14 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46092 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfBTQuN (ORCPT ); Wed, 20 Feb 2019 11:50:13 -0500 Received: by mail-pl1-f193.google.com with SMTP id o6so12488598pls.13 for ; Wed, 20 Feb 2019 08:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nKG3m6YRUQcWPNPWOoVjisIt5k7D0ETB0/hx2737aec=; b=aY/F54Td0FUf/kwF+u4o3EKkovnUgai8EFLuXcUGrzmdrpuw1wvGied7YIvakz0CBE 89Bj3pWjtuytZuvD6cJDSGLBShOxPn1j6uM2Va6+WZE8afOiJSVpsoA2rtn3jBy3EtZO +/adra/W1eVixXrFREcyFJ7HugKkBLNjuW4beFQ/Zi6epu4VbxbSJcyPvk+eNf/kInK+ Rnl07P86QjZSAUgbi3dyl0DgMaxOH9S8s4EcEgXYi8ySGn9MV+xs8ynK+Umq6wqT+mkL N2pAW/mSBOH5Bi7w4Z7pE7tDICZOFafgkYTgMQFqlJiBvrVOF/bKRT2Hk4o++AGTCGUd 5FLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nKG3m6YRUQcWPNPWOoVjisIt5k7D0ETB0/hx2737aec=; b=QtW8Z0sUu1s04pDmSAEiR47kppnXLrYdxhg36jPxdKO27SqcT1ensgE1m0WU4L+eCm sftCNPfhZMC0qoPjCiNklfb3VzBnMoh6Ab5vaOpqEyiRsgtZrKinG+dtVRaUv6qXCJEi U5ciuCorSUOPjjwaCELbegFb0hvQGsjkMDcYzmz/TIlhmA8n92q1ja+usOlUxjN/+vDy ThaUMjboTDDFFV0LisN/zk8N3N6xdK95hegoYZbQ3bYRs95TC865VVwthlmzX1JF6Wnf 0x32/6s7PEKPZhwg2lDlSyIkK++oD11il8p6DltJ6XFSropzIH6o3KRX/31i1EZO2zJA UxTA== X-Gm-Message-State: AHQUAuaHsEDrcV6cAx6SIFFL+Ik7u2XExHNvYYCeLiU3knSzEG09mHiU aBcq68opMzQ3gyvwYP67VPWc0w== X-Google-Smtp-Source: AHgI3Ia6wIoVU50hKlEa2SyNrVArSf0fSo5E1FN770grOAI33FAkxX7rhP6M4wyqI+29xtuutgQ2TA== X-Received: by 2002:a17:902:4827:: with SMTP id s36mr36762385pld.168.1550681413192; Wed, 20 Feb 2019 08:50:13 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id k128sm26169968pfc.34.2019.02.20.08.50.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 08:50:12 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gwV4V-0000WF-3p; Wed, 20 Feb 2019 09:50:11 -0700 Date: Wed, 20 Feb 2019 09:50:11 -0700 From: Jason Gunthorpe To: "Saleem, Shiraz" Cc: "dledford@redhat.com" , "davem@davemloft.net" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "Ismail, Mustafa" , "Kirsher, Jeffrey T" Subject: Re: [RFC v1 17/19] RDMA/irdma: Add ABI definitions Message-ID: <20190220165011.GE8429@ziepe.ca> References: <20190215171107.6464-1-shiraz.saleem@intel.com> <20190215171107.6464-18-shiraz.saleem@intel.com> <20190215171638.GA30706@ziepe.ca> <9DD61F30A802C4429A01CA4200E302A7A5A46077@fmsmsx124.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7A5A46077@fmsmsx124.amr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 20, 2019 at 02:52:03PM +0000, Saleem, Shiraz wrote: > >Subject: Re: [RFC v1 17/19] RDMA/irdma: Add ABI definitions > > > >On Fri, Feb 15, 2019 at 11:11:04AM -0600, Shiraz Saleem wrote: > >> From: Mustafa Ismail > >> > >> Add ABI definitions for irdma. > > [....] > >> > >> + > >> +#include > >> + > >> +#define IRDMA_ABI_VER 6 > > > >Starting with high numbers? > > It's a bump on the current i40iw ABI ver. of 5 since we > want to be compatible and support current rdma-core's libi40iw > for Gen1 (X722) device. i40iw is one of the drivers that doesn't do ABI versions right, so this is all meaningless. You should probably fix it: static const struct verbs_device_ops i40iw_udev_ops = { .name = "i40iw", .match_min_abi_version = 0, .match_max_abi_version = INT_MAX, 0 and INT_MAX need to be something sensible. > >This won't even compile like this - don't forget you have to send the rdma-core > >PR along with the kernel patches. You should already be running the travis > >checks yourself. rdma-core should detect malformed user space headers.. > > Yes. We will be sending the rdma-core patches soon. > Maybe we are missing something here, but this did compile with libirdma > in rdma-core-v22, but we havent run travis checks yet. travis does the tests. Jason