From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C54ADC43381 for ; Wed, 20 Feb 2019 16:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94F952084D for ; Wed, 20 Feb 2019 16:51:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="iJZvrZPX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726888AbfBTQvb (ORCPT ); Wed, 20 Feb 2019 11:51:31 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:39722 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfBTQva (ORCPT ); Wed, 20 Feb 2019 11:51:30 -0500 Received: by mail-pl1-f193.google.com with SMTP id 101so12498281pld.6 for ; Wed, 20 Feb 2019 08:51:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9+sjWGzmhrjF94MFXk/CBJLZkYv8aXBXAOq4Cexbsr8=; b=iJZvrZPX3GwppIVj2GRU1v5qpShyXtGn0LK/cRQCebaXHe+kFWXGw9P0pdT3fiT51d RGyVxZQ3Sa0AiWu0iBdzly3gQFYIQ+ttzeW1Z85cf48Vp7HiMxnn+Ad5fqbS74zvsHbu Tx5TOaQ15WZEAg40f8szKsGvkkcnd6/4PIKYeQgA5ivrtjOa8YL7QFqFGjCrSWa8l5kj 46KD+pEzmtMotg6ztVJpUouwql9HffHAZXAnqLXNjUIqPnR7er7P1J5HQJx96VHtAXF3 oW7ipcspNZAR88bryFB7MkMP7PkCqfQ1+OqDkohjkcqJtKNlREh/Uax6jsXvf8biYCVW /TVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9+sjWGzmhrjF94MFXk/CBJLZkYv8aXBXAOq4Cexbsr8=; b=qynx0uWl1ANZwwgBOKOGMgCDbuzY/v6WsG7rSvJz0uMqs3vG/j+xO9+iSUlu+kT5E3 OmM6b0VVsSfkR19rxzeI99SJR4W4UG4UVC8mByfPlQGz7d54EXWnRBOOZcNUHNjGiAa/ WAOa7zkU2VFeLGnGU9bT6KXxONUDeGokAjesvYhp4YOk9I4/WZXjEM43gv2R5mMIstQ7 kKfgwg7XPAoPxWgYDX6kWWUfH+c4tucuMQtOML9UYdFwR28MKj9Bt0BIWtu4KCe+PdpJ NA1KI1qLnd0W3M4kN70e8G+uvvPBEBePzYDsYO0bVuZLg1X86XR3LvIyXCPC05bahbbn q0OA== X-Gm-Message-State: AHQUAuYkofeAg7+Y4/eUBsNUwC0zn05CEG0APPSWsJvnUVDYvs0//hKI DQd3DaqHkA9OpDPgdRUCvLj7Yw== X-Google-Smtp-Source: AHgI3Ia2ju+P8lXgvehV9gXfddB1jHiM6qXMe+E8jrMH5xf5bny6XlFY9AqJNofXQTx07K3GnBQRzQ== X-Received: by 2002:a17:902:22a:: with SMTP id 39mr29699612plc.153.1550681490172; Wed, 20 Feb 2019 08:51:30 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id e9sm76955328pfh.42.2019.02.20.08.51.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 08:51:29 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gwV5l-0000Wz-49; Wed, 20 Feb 2019 09:51:29 -0700 Date: Wed, 20 Feb 2019 09:51:29 -0700 From: Jason Gunthorpe To: "Saleem, Shiraz" Cc: "dledford@redhat.com" , "davem@davemloft.net" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "Ismail, Mustafa" , "Kirsher, Jeffrey T" Subject: Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs Message-ID: <20190220165129.GF8429@ziepe.ca> References: <20190215171107.6464-1-shiraz.saleem@intel.com> <20190215171107.6464-13-shiraz.saleem@intel.com> <20190215173539.GD30706@ziepe.ca> <9DD61F30A802C4429A01CA4200E302A7A5A460A0@fmsmsx124.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7A5A460A0@fmsmsx124.amr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 20, 2019 at 02:52:31PM +0000, Saleem, Shiraz wrote: > >All lists of things should be sorted. I saw many examples of unsorted lists. > > OK. We weren't aware of this rule in kernel drivers. Is this subsystem specific? It is a general kernel preference - it helps avoid unnecessary merge conflicts. Lists in kconfig, makefiles, etc should all be sorted. Other order-independent lists, like ops, and what not should be sorted for the same reasons. > >> + iwibdev->ibdev.iwcm->add_ref = irdma_add_ref; > >> + iwibdev->ibdev.iwcm->rem_ref = irdma_rem_ref; > >> + iwibdev->ibdev.iwcm->get_qp = irdma_get_qp; > >> + iwibdev->ibdev.iwcm->connect = irdma_connect; > >> + iwibdev->ibdev.iwcm->accept = irdma_accept; > >> + iwibdev->ibdev.iwcm->reject = irdma_reject; > >> + iwibdev->ibdev.iwcm->create_listen = irdma_create_listen; > >> + iwibdev->ibdev.iwcm->destroy_listen = irdma_destroy_listen; > > > >Huh. These should probably be moved into the ops structure too. > > Not sure. It looks cleaner this way. These are iWARP CM > specific. Why allocate them for all devices? Not sure a few bytes really matter. Jason