From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5AD7C43381 for ; Wed, 20 Feb 2019 17:27:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF5D52084D for ; Wed, 20 Feb 2019 17:27:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="jxGGVK1W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbfBTR1V (ORCPT ); Wed, 20 Feb 2019 12:27:21 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60030 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfBTR1V (ORCPT ); Wed, 20 Feb 2019 12:27:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jP3Lj2vwuhJDu+i/mxWKvJzUBNzbLIsigDBqgwusN40=; b=jxGGVK1WxUk8m33hdgKbFOnYx5 Um5aUfafEoDGFl+XK8qwR6Agl7oI6/The6lCpFgCaWzoFIT9KmUb5rN+x5N12bs0YdaZQOaT1Z6en t5kQwA8HUAqwWj1dJBjmWH7fDwVmCyXiy6Hujuq4+qMESHKneYT7wLF9+XDxSArtuCAE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gwVeN-0000CV-TH; Wed, 20 Feb 2019 18:27:15 +0100 Date: Wed, 20 Feb 2019 18:27:15 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Russell King , Vivien Didelot , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: fix unintended change of bridge interface STP state Message-ID: <20190220172715.GL13075@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 20, 2019 at 09:22:30AM -0800, Florian Fainelli wrote: > On 2/20/19 2:32 AM, Russell King wrote: > > When a DSA port is added to a bridge and brought up, the resulting STP > > state programmed into the hardware depends on the order that these > > operations are performed. However, the Linux bridge code believes that > > the port is in disabled mode. > > > > If the DSA port is first added to a bridge and then brought up, it will > > be in blocking mode. If it is brought up and then added to the bridge, > > it will be in disabled mode. > > > > This difference is caused by DSA always setting the STP mode in > > dsa_port_enable() whether or not this port is part of a bridge. Since > > bridge always sets the STP state when the port is added, brought up or > > taken down, it is unnecessary for us to manipulate the STP state. > > > > Apparently, this code was copied from Rocker, and the very next day a > > similar fix for Rocker was merged but was not propagated to DSA. See > > e47172ab7e41 ("rocker: put port in FORWADING state after leaving bridge") > > > > Fixes: b73adef67765 ("net: dsa: integrate with SWITCHDEV for HW bridging") > > Signed-off-by: Russell King > > Nice example of cargo cult programming, thanks for fixing this! Maybe now would be a good time to look at other drivers. Does the Microsemi Ocelot driver have the same issue? Andrew