From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D0DC43381 for ; Thu, 21 Feb 2019 02:01:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECB112086D for ; Thu, 21 Feb 2019 02:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="iBCzMA+L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbfBUCBU (ORCPT ); Wed, 20 Feb 2019 21:01:20 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42308 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbfBUCBU (ORCPT ); Wed, 20 Feb 2019 21:01:20 -0500 Received: by mail-pl1-f195.google.com with SMTP id s1so13268898plp.9 for ; Wed, 20 Feb 2019 18:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NFyaPNW4tdPfwvB2thv236vUHkGVrW4H+TdgX5yrjkI=; b=iBCzMA+Lte3pyRQgSnZqOcObTb7eYwIG+aFog/b/EO39sQf4U4LkBShsZKItI1huLG jRtSC0qWghIF3XMAFAubwHsQXx8kq6uT+baERtyZ/SFRYEC5bUNECWehCG9hAVbzSX8Z 4yovJMkSK050R3C0B63VSUbKvkP5hegWJ9+hcUOR8GXnS8ju2VwYITc81X9xZVwg6wDV 8XbUVmJ8eqStxN0a+Vlhmlpoc9i3Hht9Q7bxJIaXbfEl5Bk2yhC7amSaemcvoW/thy6v hsuK+YHO7o3YTrN7MoP2ACeOiAk1qgdyVEIA3DLu3NV6TeKEiycvh13bATnRbPCH4V2/ 4XkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NFyaPNW4tdPfwvB2thv236vUHkGVrW4H+TdgX5yrjkI=; b=N9zCzrK0GbgprD3AFKAMbAY5gIhT/dVkv70fgwPf9VPSJvpVN9GVjWdJkF0jgjgyqv Goz9haQT7LS24o7x5BbykKKC519JUvYpNYoLpkq3y5jI/Ntz1Dpm5t4bvzpO1ZKOY0JV ZsEzxGO8dz8KoWG1GqNb+ofAXfLzIlAqzPh1wQQ41J6XZtf5FXDknMg2HodC/JiaKR1P TxH6WpPOCekpq/k20UNUR0dxJNwiHxanCDeW9ijAmuRA2CXGnfAmC9v6hb834OhEatFM 19S6UBEzxYimuGVIY11GQUKSTQ6BYvy2h64Iw2GvL61eCC94VDcLQrl/PAJ/tcpF0mLI N+AQ== X-Gm-Message-State: AHQUAubCDvkMZgbT7qCEYB6HwLx2XrPGK97fBoMQp9Sq8mytDHgboUCR qG+UQ/gHOmYLE5aO9PtZGhXnPg== X-Google-Smtp-Source: AHgI3IaghPVTI/xyzC3fLaL/QDO8FqdX0wH1RXcb2G/YHqvBJXGdV0NslKCI15aWKKkqiY3zgeK/Fw== X-Received: by 2002:a17:902:9a4a:: with SMTP id x10mr38471846plv.93.1550714479738; Wed, 20 Feb 2019 18:01:19 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k26sm33719405pfb.87.2019.02.20.18.01.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 18:01:19 -0800 (PST) Date: Wed, 20 Feb 2019 18:01:17 -0800 From: Stephen Hemminger To: Jiri Pirko Cc: netdev@vger.kernel.org, dsahern@gmail.com, mlxsw@mellanox.com Subject: Re: [patch iproute2] devlink: relax dpipe table show dependency on resources Message-ID: <20190220180117.2ad552d0@shemminger-XPS-13-9360> In-Reply-To: <20190220092109.4496-1-jiri@resnulli.us> References: <20190220092109.4496-1-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 20 Feb 2019 10:21:09 +0100 Jiri Pirko wrote: > - resource_valid = !!nla_table[DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_ID]; > + resource_valid = !!nla_table[DEVLINK_ATTR_DPIPE_TABLE_RESOURCE_ID] && > + ctx->resources; When you add a logical AND operator the !! is no longer needed. The !! convention is used to turn a value of not zero (ie not NULL) into a boolean. When you add the additional operator the result is already boolean.