From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Marcel Reichmuth <Marcel.Reichmuth@netmodule.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] net: dsa: add missing phy address offset
Date: Wed, 20 Feb 2019 20:31:22 +0100 [thread overview]
Message-ID: <20190220193122.GA5302@lunn.ch> (raw)
In-Reply-To: <d4e6e37b-01c2-3141-8e30-b7e8c252c0ef@gmail.com>
On Wed, Feb 20, 2019 at 11:27:16AM -0800, Florian Fainelli wrote:
> On 2/20/19 10:15 AM, Marcel Reichmuth wrote:
> > When phys do not start at address 0 like on the mv88e6341 the wrong
> > phy address is used and therefore the slave ports can not be
> > initialized. This patch adds the proper offset to the phy address.
> >
> > Signed-off-by: Marcel Reichmuth <marcel.reichmuth@netmodule.com>
>
> You are supposed to describe the port to PHY mapping using the binding,
> so for instance:
>
> ports {
> port@0 {
> reg = <0>;
> phy-handle = <&phy1>;
> };
>
> };
>
> mdio {
> phy1: phy@1 {
> reg = <1>;
> };
> };
>
> etc. is not that working for you?
The Espressobin does exactly this:
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
It also uses the 6341.
Andrew
next prev parent reply other threads:[~2019-02-20 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 18:15 [PATCH] net: dsa: add missing phy address offset Marcel Reichmuth
2019-02-20 19:27 ` Florian Fainelli
2019-02-20 19:31 ` Andrew Lunn [this message]
2019-02-21 7:53 ` Marcel Reichmuth
2019-02-21 13:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220193122.GA5302@lunn.ch \
--to=andrew@lunn.ch \
--cc=Marcel.Reichmuth@netmodule.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).