From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B273C43381 for ; Thu, 21 Feb 2019 18:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 053442083B for ; Thu, 21 Feb 2019 18:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728084AbfBUSU5 (ORCPT ); Thu, 21 Feb 2019 13:20:57 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40854 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbfBUSU4 (ORCPT ); Thu, 21 Feb 2019 13:20:56 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D06F91457FBCF; Thu, 21 Feb 2019 10:20:55 -0800 (PST) Date: Thu, 21 Feb 2019 10:20:55 -0800 (PST) Message-Id: <20190221.102055.331192649932336315.davem@davemloft.net> To: ubraun@linux.ibm.com Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, raspl@linux.ibm.com Subject: Re: [PATCH net 1/1] net/smc: fix smc_poll in SMC_INIT state From: David Miller In-Reply-To: <20190221115654.3889-1-ubraun@linux.ibm.com> References: <20190221115654.3889-1-ubraun@linux.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Feb 2019 10:20:56 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ursula Braun Date: Thu, 21 Feb 2019 12:56:54 +0100 > smc_poll() returns with mask bit EPOLLPRI if the connection urg_state > is SMC_URG_VALID. Since SMC_URG_VALID is zero, smc_poll signals > EPOLLPRI errorneously if called in state SMC_INIT before the connection > is created, for instance in a non-blocking connect scenario. > > This patch switches to non-zero values for the urg states. > > Reviewed-by: Karsten Graul > Fixes: de8474eb9d50 ("net/smc: urgent data support") > Signed-off-by: Ursula Braun Applied and queued up for -stable.