From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F611C43381 for ; Thu, 21 Feb 2019 20:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42B77207E0 for ; Thu, 21 Feb 2019 20:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbfBUUxl convert rfc822-to-8bit (ORCPT ); Thu, 21 Feb 2019 15:53:41 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42726 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbfBUUxk (ORCPT ); Thu, 21 Feb 2019 15:53:40 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F1D5E145E8368; Thu, 21 Feb 2019 12:53:39 -0800 (PST) Date: Thu, 21 Feb 2019 12:53:37 -0800 (PST) Message-Id: <20190221.125337.93418174369939715.davem@davemloft.net> To: jeffrey.t.kirsher@intel.com Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com Subject: Re: [net 0/5][pull request] Intel Wired LAN Driver Fixes 2019-02-21 From: David Miller In-Reply-To: <20190221193319.22318-1-jeffrey.t.kirsher@intel.com> References: <20190221193319.22318-1-jeffrey.t.kirsher@intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Feb 2019 12:53:40 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jeff Kirsher Date: Thu, 21 Feb 2019 11:33:14 -0800 > This series contains fixes to ixgbe and i40e. > > Majority of the fixes are to resolve XDP issues found in both drivers, > there is only one fix which is not XDP related. That one fix resolves > an issue seen on older 10GbE devices, where UDP traffic was either being > dropped or being transmitted out of order when the bit to enable L3/L4 > filtering for transmit switched packets is enabled on older devices that > did not support this option. > > Magnus fixes an XDP issue for both ixgbe and i40e, where receive rings > are created but no buffers are allocated for AF_XDP in zero-copy mode, > so no packets can be received and no interrupts will be generated so > that NAPI poll function that allocates buffers to the rings will never > get executed. > > Björn fixes a race in XDP xmit ring cleanup for i40e, where > ndo_xdp_xmit() must be taken into consideration. Added a > synchronize_rcu() to wait for napi(s) before clearing the queue. > > Jan fixes a ixgbe AF_XDP zero-copy transmit issue which can cause a > reset to be triggered, so add a check to ensure that netif carrier is > 'ok' before trying to transmit packets. Pulled, thanks Jeff.