From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63125C43381 for ; Thu, 21 Feb 2019 21:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 398E42080F for ; Thu, 21 Feb 2019 21:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbfBUVLa (ORCPT ); Thu, 21 Feb 2019 16:11:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43066 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbfBUVL3 (ORCPT ); Thu, 21 Feb 2019 16:11:29 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 41FEE145EE2BE; Thu, 21 Feb 2019 13:11:29 -0800 (PST) Date: Thu, 21 Feb 2019 13:11:28 -0800 (PST) Message-Id: <20190221.131128.1615110783597157620.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: jhs@mojatatu.com, vladbu@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: sched: potential NULL dereference in tcf_block_find() From: David Miller In-Reply-To: <20190218092632.GB7712@kadam> References: <20190218092632.GB7712@kadam> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Feb 2019 13:11:29 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Mon, 18 Feb 2019 12:26:32 +0300 > The error code isn't set on this path so it would result in returning > ERR_PTR(0) and a NULL dereference in the caller. > > Fixes: 18d3eefb17cf ("net: sched: refactor tcf_block_find() into standalone functions") > Signed-off-by: Dan Carpenter Applied, thanks.