From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: improve definition of __ETHTOOL_LINK_MODE_MASK_NBITS
Date: Thu, 21 Feb 2019 13:47:10 -0800 (PST) [thread overview]
Message-ID: <20190221.134710.664760955065013346.davem@davemloft.net> (raw)
In-Reply-To: <d65a539b-dff7-6a00-3166-df47a9efcf0f@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 18 Feb 2019 21:43:31 +0100
> The way to define __ETHTOOL_LINK_MODE_MASK_NBITS seems to be overly
> complicated, go with a standard approach instead.
> Whilst we're at it, move the comment to the right place.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Hey Heiner, you'll have to respin this after the recent mlx5 pull
into net-next which added new mode values.
Thanks.
prev parent reply other threads:[~2019-02-21 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 20:43 [PATCH net-next] net: phy: improve definition of __ETHTOOL_LINK_MODE_MASK_NBITS Heiner Kallweit
2019-02-21 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221.134710.664760955065013346.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox