From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, willemb@google.com
Subject: Re: [PATCH net] net: avoid false positives in untrusted gso validation
Date: Thu, 21 Feb 2019 14:08:49 -0800 (PST) [thread overview]
Message-ID: <20190221.140849.2117139861357774917.davem@davemloft.net> (raw)
In-Reply-To: <20190219043712.97121-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Mon, 18 Feb 2019 23:37:12 -0500
> From: Willem de Bruijn <willemb@google.com>
>
> GSO packets with vnet_hdr must conform to a small set of gso_types.
> The below commit uses flow dissection to drop packets that do not.
>
> But it has false positives when the skb is not fully initialized.
> Dissection needs skb->protocol and skb->network_header.
>
> Infer skb->protocol from gso_type as the two must agree.
> SKB_GSO_UDP can use both ipv4 and ipv6, so try both.
>
> Exclude callers for which network header offset is not known.
>
> Fixes: d5be7f632bad ("net: validate untrusted gso packets without csum offload")
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-02-21 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 4:37 [PATCH net] net: avoid false positives in untrusted gso validation Willem de Bruijn
2019-02-21 22:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221.140849.2117139861357774917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox