From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63866C43381 for ; Thu, 21 Feb 2019 23:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A86B2080D for ; Thu, 21 Feb 2019 23:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfBUX6E (ORCPT ); Thu, 21 Feb 2019 18:58:04 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44916 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfBUX6E (ORCPT ); Thu, 21 Feb 2019 18:58:04 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C9CC61469B9E0; Thu, 21 Feb 2019 15:58:03 -0800 (PST) Date: Thu, 21 Feb 2019 15:58:03 -0800 (PST) Message-Id: <20190221.155803.761850505171399497.davem@davemloft.net> To: idosch@mellanox.com Cc: netdev@vger.kernel.org, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com Subject: Re: [PATCH net-next 00/10] mlxsw: Support for shared buffers in Spectrum-2 From: David Miller In-Reply-To: <20190220193141.16498-1-idosch@mellanox.com> References: <20190220193141.16498-1-idosch@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Feb 2019 15:58:04 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Date: Wed, 20 Feb 2019 19:32:10 +0000 > Petr says: > > Spectrum-2 will be configured with a different set of pools than > Spectrum-1, their sizes will be larger, and the individual quotas will > be different as well. It is therefore necessary to make the shared > buffer module aware of this dependence on chip type, and adjust the > individual tables. > > In patch #1, introduce a structure for keeping per-chip immutable and > default values. > > In patch #2, structures for keeping current values of SBPM and SBPR > (pool configuration and port-pool quota) are allocated dynamically to > support varying pool counts. > > In patches #3 to #7, uses of individual shared buffer configuration > tables are migrated from global definitions to fields in struct > mlxsw_sp_sb_vals, which was introduced above. > > Up until this point, the actual configuration is still the one suitable > for Spectrum-1. In patch #8 Spectrum-2 configuration is added. > > In patch #9, port headroom configuration is changed to take into account > current recommended value for a 100-Gbps port, and the split factor. > > In patch #10, requests for overlarge headroom are rejected. This avoids > potential chip freeze should such overlarge requests be made. Series applied, thanks.