From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D808DC43381 for ; Thu, 21 Feb 2019 00:39:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A25C206BB for ; Thu, 21 Feb 2019 00:39:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="LEuqVpok" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbfBUAjD (ORCPT ); Wed, 20 Feb 2019 19:39:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60399 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbfBUAjD (ORCPT ); Wed, 20 Feb 2019 19:39:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kd38fWLUgboH2+QcZzZUX7gRJ9WiMN3GZ22g2Q1h170=; b=LEuqVpokL8xJfqOJ1qE4V/aOLN o+Kx8aK/y4GhOzTLhYcxAU7cWaNTf5rxcAiNcsVDo4+bgSsVdiwzD12Mu4UqeIWA00soD/2onXB+B BccTns1db8KNX1lz9FBBDjX1T7KwnhpogIo1fo9WbTj4YrgvufF5XUMmANBTuRZmMadE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gwcO7-00046y-7u; Thu, 21 Feb 2019 01:38:55 +0100 Date: Thu, 21 Feb 2019 01:38:55 +0100 From: Andrew Lunn To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Vinod Koul , Heiner Kallweit , "David S. Miller" , Florian Fainelli , netdev@vger.kernel.org Subject: Re: [RFC] net: dsa: qca8k: CPU port broken with commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") Message-ID: <20190221003855.GP14879@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 20, 2019 at 04:02:32PM +0100, Michal Vokáč wrote: > Hi, > > Another issue in a row with networking on imx6dl-yapp4 platform [1] > that uses QCA8334 Ethernet switch. > > Very recently, with Vinod and Andrew, we solved an issue with > RGMII_ID mode by patch[2][3]. I tested those with next-20190215 > and it worked just fine. > > The patch[2] was merged into next-20190220 so I tested the latest version. > Now the cpu port does not work again. I tracked it down to this commit > 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in > genphy_read_status") [4] > > If I revert the offending commit, cpu port works fine. I suspect the > problem is on the qca8k driver side but I am not really sure. > AFAICT autonegotiation is not available on the QCA833x cpu port (MAC0). > > Any ideas what may be the root cause of the problem? Hi Michal I would suggest taking a look at dsa_port_fixed_link_register_of(). It might be a bit more state needs initialising before calling genphy_read_status()? Andrew