From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
Alexei Starovoitov <ast@kernel.org>,
Christian Brauner <christian@brauner.io>,
Daniel Borkmann <daniel@iogearbox.net>,
David Ahern <dsahern@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@mellanox.com>,
Ingo Molnar <mingo@redhat.com>,
intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET
DRIVERS), Jakub Kicinski <jakub.kicinski@netronome.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
keescook@chromium.org, Lai Jiangshan <jiangshanlai@gmail.com>,
Martin KaFai Lau <kafai@fb.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
netdev@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
rcu@vger.kernel.org, Song Liu <songliubraving@fb.com>,
Steven Rostedt <rostedt@goodmis.org>,
xdp-newbies@vger.kernel.org, Yonghong Song <yhs@fb.com>
Subject: [PATCH RFC 0/5] RCU fixes for rcu_assign_pointer() usage
Date: Thu, 21 Feb 2019 00:49:37 -0500 [thread overview]
Message-ID: <20190221054942.132388-1-joel@joelfernandes.org> (raw)
These patches fix various RCU API usage issues found due to sparse errors as a
result of the recent check to add rcu_check_sparse() to rcu_assign_pointer().
The errors in many cases seem to indicate either an incorrect API usage, or
missing annotations. The annotations added can also help avoid future incorrect
usages and bugs so it is a good idea to do in any case.
These are only build/boot tested and I request for feedback from maintainers
and developers in the various areas the patches touch. Thanks for any feedback!
(There are still errors in rbtree.h but I have kept those for a later time
since fixing them is a bit more involved).
Joel Fernandes (Google) (5):
net: rtnetlink: Fix incorrect RCU API usage
ixgbe: Fix incorrect RCU API usage
sched/cpufreq: Fix incorrect RCU API usage
sched/topology: Annonate RCU pointers properly
rcuwait: Replace rcu_assign_pointer() with WRITE_ONCE
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 ++++++++++++-----
include/linux/rcuwait.h | 2 +-
kernel/sched/cpufreq.c | 8 ++++++--
kernel/sched/sched.h | 14 +++++++-------
kernel/sched/topology.c | 12 ++++++------
net/core/rtnetlink.c | 4 ++--
7 files changed, 36 insertions(+), 25 deletions(-)
--
2.21.0.rc0.258.g878e2cd30e-goog
next reply other threads:[~2019-02-21 5:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 5:49 Joel Fernandes (Google) [this message]
2019-02-21 5:49 ` [PATCH RFC 1/5] net: rtnetlink: Fix incorrect RCU API usage Joel Fernandes (Google)
2019-02-21 5:49 ` [PATCH RFC 2/5] ixgbe: " Joel Fernandes (Google)
2019-02-21 5:49 ` [PATCH RFC 3/5] sched/cpufreq: " Joel Fernandes (Google)
2019-02-21 9:18 ` Peter Zijlstra
2019-02-21 15:21 ` Joel Fernandes
2019-02-21 15:31 ` Peter Zijlstra
2019-02-21 15:52 ` Paul E. McKenney
2019-02-21 16:11 ` Peter Zijlstra
2019-02-21 17:13 ` Joel Fernandes
2019-02-21 17:29 ` Paul E. McKenney
2019-02-21 16:17 ` Steven Rostedt
2019-02-21 23:05 ` Rafael J. Wysocki
2019-02-21 5:49 ` [PATCH RFC 4/5] sched/topology: Annonate RCU pointers properly Joel Fernandes (Google)
2019-02-21 9:19 ` Peter Zijlstra
2019-02-21 15:10 ` Joel Fernandes
2019-02-21 15:29 ` Peter Zijlstra
2019-02-21 17:17 ` Joel Fernandes
2019-02-21 5:49 ` [PATCH RFC 5/5] rcuwait: Replace rcu_assign_pointer() with WRITE_ONCE Joel Fernandes (Google)
2019-02-21 9:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221054942.132388-1-joel@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=ast@kernel.org \
--cc=christian@brauner.io \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hawk@kernel.org \
--cc=idosch@mellanox.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiangshanlai@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=xdp-newbies@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).