From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F3BC43381 for ; Thu, 21 Feb 2019 10:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B12620855 for ; Thu, 21 Feb 2019 10:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550744627; bh=NUIArXE8JiDAnTDGHeZivMGIAHofHYYeluAZ74sT25g=; h=From:To:Cc:Subject:Date:List-ID:From; b=pxTs0KxDbyo0FDD/wsO7ueqMnhssD4ObXNEfMd3PkXVuXhqG9rOocoNfAoJvcLLD/ XNfdnbnJKFz2DkCUe+3SZUP8u7U+2bAU2EEIT03o7+2XeIH59FDR4um8zRCVVteCOJ gaTJEcd9O29UivF71s71WRuTMUpcHOuJ53psCO7c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbfBUKXq (ORCPT ); Thu, 21 Feb 2019 05:23:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:42528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfBUKXq (ORCPT ); Thu, 21 Feb 2019 05:23:46 -0500 Received: from localhost.localdomain (unknown [171.76.105.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8F1C20836; Thu, 21 Feb 2019 10:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550744625; bh=NUIArXE8JiDAnTDGHeZivMGIAHofHYYeluAZ74sT25g=; h=From:To:Cc:Subject:Date:From; b=G+KBj7IhOg7oXcDukFfO7DKCxh1v67iE5UQk6OQWp2sFstgPO3u8eg2mEu1Vsbs/b NKshazwoSnWJSgUYh/DK4GFWONiGb41JHCRAU3R/SJYuCQwBYXUYIoEzPRmn8sHgUn EclPWySrhLRNUYqQFmQOjqupOfEoumiWZFE8oeFY= From: Vinod Koul To: David S Miller Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , netdev@vger.kernel.org, Niklas Cassel , Andrew Lunn , Florian Fainelli , "Nori, Sekhar" , Peter Ujfalusi , Marc Gonzalez Subject: [PATCH net-next v4 0/2] net: phy: at803x: Update delays for RGMII modes Date: Thu, 21 Feb 2019 15:53:13 +0530 Message-Id: <20190221102315.12946-1-vkoul@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") caused regression on am335x-evmsk board. This board expects the Phy delay to be enabled but specified RGMII mode which refers to delays being disabled. So fix this by disabling delay only for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. While at it, as pointed by Dave, don't inline the helpers. [1]: https://www.spinics.net/lists/netdev/msg550749.html Changes in v4: - fix log & comments nbased on Marc's feedback Vinod Koul (2): net: phy: at803x: don't inline helpers net: phy: at803x: disable delay only for RGMII mode drivers/net/phy/at803x.c | 57 +++++++++++++++++++++++++++++++--------- 1 file changed, 44 insertions(+), 13 deletions(-) -- 2.20.1