From: Andrew Lunn <andrew@lunn.ch>
To: Marcel Reichmuth <Marcel.Reichmuth@netmodule.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] net: dsa: add missing phy address offset
Date: Thu, 21 Feb 2019 14:10:37 +0100 [thread overview]
Message-ID: <20190221131037.GA5653@lunn.ch> (raw)
In-Reply-To: <20190221075333.t7vikxznp3l6ello@debian>
> Thank you very much for your hints. Yes that works indeed too. I
> just assumed it was intended to work automatically with the
> built-in phys as it does with the other switches I am using.
Hi Marcel
The basic assumption is there is a one to one mapping of port number
to PHY address. All the other Marvell switch have this mapping.
Since the needed flexibility exists to support this, and Marvell has
not repeated this odd design, i decided not to do anything about it in
code.
Andrew
prev parent reply other threads:[~2019-02-21 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 18:15 [PATCH] net: dsa: add missing phy address offset Marcel Reichmuth
2019-02-20 19:27 ` Florian Fainelli
2019-02-20 19:31 ` Andrew Lunn
2019-02-21 7:53 ` Marcel Reichmuth
2019-02-21 13:10 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221131037.GA5653@lunn.ch \
--to=andrew@lunn.ch \
--cc=Marcel.Reichmuth@netmodule.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).