From: Andrew Lunn <andrew@lunn.ch>
To: Rundong Ge <rdong.ge@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: m88e6390_config_aneg will always reset the phy
Date: Thu, 21 Feb 2019 14:25:58 +0100 [thread overview]
Message-ID: <20190221132558.GB5653@lunn.ch> (raw)
In-Reply-To: <CAN1LvyqjHCCNxz30a-SMO3uSBw2WD-Mvn4sR==9SUcJKdqo9vA@mail.gmail.com>
On Thu, Feb 21, 2019 at 06:55:54PM +0800, Rundong Ge wrote:
> Hi Andrew
>
> Before the "net: phy: marvell: Errata for mv88e6390 internal PHYs",
> phydev will only be soft reset when register value was changed.
> But after this patch, the phydev will always be reset when entering
> the "m88e6390_config_aneg".
> So is there any side effect of this change?
Hi Rundong
I tried to avoid the reset, but it does not appear you can read back
the magic values which got poked into the magic registers. So there is
no way to tell if the Errata has already been applied, e.g. by the
boot loader.
Side effects?
The PHY might work :-)
It might take a little bit longer to report link up, since there is an
additional soft reset.
Andrew
prev parent reply other threads:[~2019-02-21 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:55 m88e6390_config_aneg will always reset the phy Rundong Ge
2019-02-21 13:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221132558.GB5653@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdong.ge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox