From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60242C43381 for ; Thu, 21 Feb 2019 14:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22B272070B for ; Thu, 21 Feb 2019 14:18:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="njd6d5v9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbfBUOST (ORCPT ); Thu, 21 Feb 2019 09:18:19 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41504 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfBUOSS (ORCPT ); Thu, 21 Feb 2019 09:18:18 -0500 Received: by mail-wr1-f66.google.com with SMTP id n2so18345010wrw.8 for ; Thu, 21 Feb 2019 06:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VmdQDjUalhovI+wQ8yTSEpK/elv9osi0iss1NvaLE48=; b=njd6d5v9mDKnWryFXFHiaAHfucyOT1R8+nA0Ms6ghJj6rxqAiARyxCRg0MWjlQ8NWx 7Vg1BMEuxL2mSZahXc6yzOVG6lzCKNA9L1swmVofXBLDofXiHWlG7JjAYgzIfYvEM8CE oaPTST8EqLoAspW27To3J9IBtRYmqTyr8L0lOK+Oqp78Afm44dMiqr9Lb2KaCfMjEzdX Wp7MYw6z6ytr+pRrEKKxfuez+8qhEuPxlfGK4Fxg4MDDv1BT28e5JLFbPPZ9uhme6YJV rLpGEAnWwBYjEPLexfqXsWRhAZfKHTLw8oNbqjKIADqJLBHQcLema/1/AkjL4dDNJU2z IfTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VmdQDjUalhovI+wQ8yTSEpK/elv9osi0iss1NvaLE48=; b=mxNjClvWYxCGWrpyvQA9Ax5p2VyqscgYOsr4Fk1cZacSAarlK2LVUKxWQtUX1umZz0 gYUxBJ4/txRlZnND5D+W9I81lkiyQgo3bTwnRMeDkwuxRoscF/+Imd7fN4cRnn462hPY NchCANtP+3/YIC8s/hs2vgDr3MvPO1M63mF4Ndt5rw3+0mtVCctPnOcbQza5w0VkLYOi Q2iA5ao22b2Y7GGKkKN55x+AZlsBk+uH80qR3tCa4drUH+Tge+iUXUP0aLWmdWLY1Q3q fOQg7sxFqfXvvtUFNQM2tzXGdCznT5ZBIZYa1udlnPCwDI7OncBlCJYWYY3JL3NiU98N A1fA== X-Gm-Message-State: AHQUAubu5CUvAW3tRiIAziz8ytR8OueumG8Hsz/5ZxQzReKrqLqntdRT 6pU4+RWDQVYIKKEOPdL91YBpSw== X-Google-Smtp-Source: AHgI3IavQGWXs9ftSP1VKb0j0sTN2oOqUaFj4GYRrSMoVXq0v44oVv8/uoFwxchsVg5qPiKbKl52kA== X-Received: by 2002:a5d:6641:: with SMTP id f1mr29404316wrw.279.1550758697134; Thu, 21 Feb 2019 06:18:17 -0800 (PST) Received: from localhost (ip-89-102-139-73.net.upcbroadband.cz. [89.102.139.73]) by smtp.gmail.com with ESMTPSA id e7sm31088337wrw.35.2019.02.21.06.18.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 06:18:16 -0800 (PST) Date: Thu, 21 Feb 2019 15:08:37 +0100 From: Jiri Pirko To: Aya Levin Cc: David Ahern , netdev@vger.kernel.org, Jiri Pirko , Moshe Shemesh , Eran Ben Elisha Subject: Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately Message-ID: <20190221140837.GO2312@nanopsycho> References: <1550756567-18227-1-git-send-email-ayal@mellanox.com> <1550756567-18227-5-git-send-email-ayal@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550756567-18227-5-git-send-email-ayal@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Feb 21, 2019 at 02:42:40PM CET, ayal@mellanox.com wrote: >Add a new helper functions which outputs only values (without name >label) for different types: boolean, uint, uint64, string and binary. >In addition add a helper function which prints only the name label. > >Signed-off-by: Aya Levin >Reviewed-by: Moshe Shemesh >--- > devlink/devlink.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 65 insertions(+), 1 deletion(-) > >diff --git a/devlink/devlink.c b/devlink/devlink.c >index b073ae020d52..5d69c4f24f29 100644 >--- a/devlink/devlink.c >+++ b/devlink/devlink.c >@@ -1588,7 +1588,6 @@ static void pr_out_port_handle_end(struct dl *dl) > pr_out("\n"); > } > >- Please avoid changes like this. [...]