From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F018C43381 for ; Thu, 21 Feb 2019 14:50:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CB2D2077B for ; Thu, 21 Feb 2019 14:50:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="VCsygF2S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728953AbfBUOuX (ORCPT ); Thu, 21 Feb 2019 09:50:23 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39144 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728005AbfBUOi1 (ORCPT ); Thu, 21 Feb 2019 09:38:27 -0500 Received: by mail-wr1-f65.google.com with SMTP id l5so29562960wrw.6 for ; Thu, 21 Feb 2019 06:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cQuDj/lKjPjmKI5kcKRLQbnQ82JohwJXz1kGMnZOShw=; b=VCsygF2SfWb0pQAiqJiQ0XI/6+dfUC0riWAjsgwXaZhCC/2G0mabd2/lOU+FgT98Xr RCLjZcoPmit/feS9L1LzviUm7bxgKeRuS/t3dIbVEpyAAueUyZfAPuAcE/3bkuJOASjY QS4ZTid8o3zV93d7lE2DCsbOwzrJO/onnfuKyoR63NhTzlqaYNd11OmR6fqhXIJGLl+Y F2mGfuNLSAREta9f7IpBYYv25TIVEZY1a3qVg3tYUKiJHZz3ICF+DsEqVCib3Jw8hEuc qQ2q0sjKn8MNfige5SRGndHrwO3k6hFC5jFqVKwfLASx9z7QsIDCF4dL7AT2kTMFQHFK k4Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cQuDj/lKjPjmKI5kcKRLQbnQ82JohwJXz1kGMnZOShw=; b=j8uFBEWmI1E4LTsk2afRsOpulYSX1Q7CbScpjw7os/44IqbsM+eltxBG6uuT80GF2f BdBGLy6iz09SW7/5jWdWbeKPMzSL+2sDF4yFYpOYuBg+t5BkfBnzwfwfWYywGFmW94bw l6+IlH5Jv//+9ei/HZI/UwZJ0TG7TYfuYudRG4LET5ZzC3KAfSrqq2XyzhkC1aWlrx8e priH0sqtXQFa0+MQQhPjO0CEI/cXAZC6wldizsvlhTak8nzki7rmyLC7TyMvGYz4LESy FrpSa3Tw4wSM/I6zMm0z7QS7iAk+PQYAt4LNJhEZFnZh1LabdKeEA5cd/dS7Z6H1RCWh TMVg== X-Gm-Message-State: AHQUAuZXyX9hq3eLfklJ5CQtcyzqdGm77oWamPHs0vUcGVl6vvjzogai h6cTTbjox8wXVpspIwbwbD0E8vlwKdk= X-Google-Smtp-Source: AHgI3IbsEA8oAERbY6EcdbVGb4LfKbmY61zIkKQFKztjZ3cgQIPoBU0wFERPd7lzDvAUV8cUYaUlbA== X-Received: by 2002:a1c:9693:: with SMTP id y141mr11134693wmd.33.1550759905715; Thu, 21 Feb 2019 06:38:25 -0800 (PST) Received: from localhost (ip-89-102-139-73.net.upcbroadband.cz. [89.102.139.73]) by smtp.gmail.com with ESMTPSA id f17sm4994325wmh.40.2019.02.21.06.38.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 06:38:25 -0800 (PST) Date: Thu, 21 Feb 2019 15:28:46 +0100 From: Jiri Pirko To: Aya Levin Cc: David Ahern , netdev@vger.kernel.org, Jiri Pirko , Moshe Shemesh , Eran Ben Elisha Subject: Re: [PATCH v2 iproute2-next 07/11] devlink: Add devlink health diagnose command Message-ID: <20190221142846.GQ2312@nanopsycho> References: <1550756567-18227-1-git-send-email-ayal@mellanox.com> <1550756567-18227-8-git-send-email-ayal@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550756567-18227-8-git-send-email-ayal@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Feb 21, 2019 at 02:42:43PM CET, ayal@mellanox.com wrote: >Add devlink health diagnose command: enabling retrieval of diagnostics data >by the user on a reporter on a device. The command's output is a >free text defined by the reporter. > >This patch also introduces an infra structure for flexible format >output. This allow the command to display different data fields >according to the reporter. >Example: >$ devlink health diagnose pci/0000:00:0a.0 reporter tx >SQs: > sqn: 4403 HW state: 1 stopped: false > sqn: 4408 HW state: 1 stopped: false > sqn: 4413 HW state: 1 stopped: false > sqn: 4418 HW state: 1 stopped: false > sqn: 4423 HW state: 1 stopped: false > >$ devlink health diagnose pci/0000:00:0a.0 reporter tx -jp >{ > "SQs":[ > { > "sqn":4403, > "HW state":1, > "stopped":false > }, > { > "sqn":4408, > "HW state":1, > "stopped":false > }, > { > "sqn":4413, > "HW state":1, > "stopped":false > }, > { > "sqn":4418, > "HW state":1, > "stopped":false > }, > { > "sqn":4423, > "HW state":1, > "stopped":false > } > ] >} > >Signed-off-by: Aya Levin >Reviewed-by: Moshe Shemesh Acked-by: Jiri Pirko