From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD779C43381 for ; Thu, 21 Feb 2019 22:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CDF1207E0 for ; Thu, 21 Feb 2019 22:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="SFvVBxH5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbfBUWta (ORCPT ); Thu, 21 Feb 2019 17:49:30 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46573 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfBUWta (ORCPT ); Thu, 21 Feb 2019 17:49:30 -0500 Received: by mail-pg1-f195.google.com with SMTP id 196so109888pgf.13 for ; Thu, 21 Feb 2019 14:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KPpaE9I0RKPVxNWiO+U7a0ZQs4LMMCuj2U3yr7TQog=; b=SFvVBxH50/DyYJeorbrIOwqHBk9NsQ99I2pf6eYDD984YAWpUu4kfG69VpK71Icxkr Ay3lynWLej4JK5VByFDLq7OtLhmOX7DadXfcp/e1xlFzp+OKAZdT1oe7f46yZGT3Scgj 0daPD0T+bCfH5cmYfqbWYkqmKx6CTlKL9CRLpL4oMYM0AAQnvJ1szy9LLJr4ViNEdBuV EoA3V3FWsK7ac64vIpa7nv0EQ8n6NG4SvVmV2wdK94pweR9tpL4de55mBmJB+EiIAZ8F AsAar5DhYM0Cv8Wr1O5HNngwOIMHtQZaCrc4jqqP88LXwYEGaFFamDgQ6Kzhxyfcfbdo pCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KPpaE9I0RKPVxNWiO+U7a0ZQs4LMMCuj2U3yr7TQog=; b=MivFvZXNK2clPWIMJOxb/PvTvMnYFN0TOys1RrFyv09tZfC5+wcS5Y1I0VDDLKkp+u 8oVMPjF2qD3sRVoWNI3CSt8LSmZkgB6IQUeOaYBT5t8IKZ3k1/M67xpIgvoUZhKUoH5o YL29tEffm/8yV7DOVbj/OV7Uh4pV3mM0L4WFQFqkBV5rQ4U+XTvwWJNZjFY/dC8kICKm I1dkTQkRew1zxM6KCkhZfm3QYbHY6NmPbYANEtCoKNup7Y5Unrr1o9XY3E2OiY5tDNXp jiLqX0CFLBkBWkKJKdilox5gqoWZwIrdStiAlIPDeXk8E3GtGvqFnjKicAICaPzi3WUy dF6Q== X-Gm-Message-State: AHQUAuafEdO39P2lHuxqlNMzSemeXiIJzc3YxA810IjzrCSimBfdIVi9 NdzurHsO8t4i6d2bumfY6OwIHg== X-Google-Smtp-Source: AHgI3IZlk/YS5es/6Zo/XOAuZguXNJVvhySw5k0aakjVTgcHudVjNrmZ5kyWJkcwpZf5sIYBwKvQcg== X-Received: by 2002:a62:6453:: with SMTP id y80mr862719pfb.203.1550789369595; Thu, 21 Feb 2019 14:49:29 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l5sm82866pgl.51.2019.02.21.14.49.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 14:49:29 -0800 (PST) Date: Thu, 21 Feb 2019 14:49:26 -0800 From: Stephen Hemminger To: Thomas De Schampheleire Cc: netdev@vger.kernel.org, Thomas De Schampheleire Subject: Re: [PATCH iproute2] ss: fix compilation under glibc < 2.18 Message-ID: <20190221144926.1bab45f6@shemminger-XPS-13-9360> In-Reply-To: References: <20190220144151.17943-1-patrickdepinguin@gmail.com> <20190220175345.34de8462@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 21 Feb 2019 08:43:08 +0100 Thomas De Schampheleire wrote: > El jue., 21 feb. 2019 a las 2:53, Stephen Hemminger > () escribi=C3=B3: > > > > On Wed, 20 Feb 2019 15:41:51 +0100 > > Thomas De Schampheleire wrote: > > =20 > > > From: Thomas De Schampheleire > > > > > > Commit c759116a0b2b6da8df9687b0a40ac69050132c77 introduced support for > > > AF_VSOCK. This define is only provided since glibc version 2.18, so > > > compilation fails when using older toolchains. > > > > > > Provide the necessary definitions if needed. > > > > > > Signed-off-by: Thomas De Schampheleire =20 > > > > Not sure why you would want new iproute2 with a 5 year old version of g= libc? > > Yes that means update your tool chain. > > =20 >=20 > This problem is noticed for an embedded system. It has up-to-date > applications and libraries (built via Buildroot) but the toolchain and > kernel are supplied by the SoC vendor (in this case Marvell, formerly > Cavium Networks). Unfortunately their toolchain is lagging behind and > is still using glibc 2.16. >=20 > I could handle this patch locally, but I think there may be other > people in a similar situation which would benefit from an upstream > fix. OK applied, just don't want to keep lots of old cruft in the code since it can lead to future suprise bugs.