From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EB9C43381 for ; Thu, 21 Feb 2019 15:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 571C12083B for ; Thu, 21 Feb 2019 15:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NYgsnf5d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbfBUPSA (ORCPT ); Thu, 21 Feb 2019 10:18:00 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33214 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfBUPR6 (ORCPT ); Thu, 21 Feb 2019 10:17:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sQYFIVjcg38tWPSrH6KAu1aCJIWgVUT5g6mKK6W/RT0=; b=NYgsnf5dyGtnyu/Rv35H3zwsQs zBw0ijGtThr1N6oYD0WsDMSL71GFGlsVfah1AgIEk5XDDjXYpRT2w8C0bzhKzdi7tCB0LZ3ZUmy9f SqddzDYjDLCfg4TEZeweqjZrQDPodqe3O+vO4Rhxwxb7C14jGqlpOxnJG+Bvunj3mR0Q=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gwq6j-00039g-Da; Thu, 21 Feb 2019 16:17:53 +0100 Date: Thu, 21 Feb 2019 16:17:53 +0100 From: Andrew Lunn To: Pankaj Bansal Cc: Leo Li , Peter Rosin , Florian Fainelli , Heiner Kallweit , "netdev@vger.kernel.org" Subject: Re: [PATCH] drivers: net: phy: mdio-mux: Add support for Generic Mux controls Message-ID: <20190221151753.GC5894@lunn.ch> References: <20190221182516.4700-1-pankaj.bansal@nxp.com> <20190221134213.GD5653@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > config MDIO_BUS_MUX > > > tristate > > > depends on OF_MDIO > > > + select MULTIPLEXER > > > help > > > This module provides a driver framework for MDIO bus > > > multiplexers which connect one of several child MDIO busses > > > > Hi Pankaj > > > > Please add a MDIO_BUS_MUX_MULTIPLEXER and put all the code into mdio- > > mux-multiplexer.c > > Isn't MUX short for MULTIPLEXER ? wouldn't this be more confusing ? Look at the pattern: config MDIO_BUS_MUX config MDIO_BUS_MUX_BCM_IPROC config MDIO_BUS_MUX_GPIO config MDIO_BUS_MUX_MMIOREG You are adding another sort of MUX, A Mux that uses a kernel Multiplexer. Hence the name should be MDIO_BUS_MUX_MULTIPLEXER. You can try to avoid confusion by using good help text: help This module provides a driver for MDIO bus multiplexer that is controlled via the kernel multiplexer subsystem. The bus multiplexer connects one of several child MDIO busses to a parent bus. Child bus selection is under the control of the kernel multiplexer subsystem. This test basically follows the other MDIO multiplexers. Andrew